Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2435413002: Use a converter for building style value for 'transform' (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a converter for building style value for 'transform' Also change TransformBuilder::createTransformOperations to return the TransformOperations rather than use an out argument. Committed: https://crrev.com/19dbf3f3adb3bc0406cf8b5862b2bede11d6f36b Cr-Commit-Position: refs/heads/master@{#427036}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
fs
4 years, 2 months ago (2016-10-21 20:51:41 UTC) #4
alancutter (OOO until 2018)
lgtm
4 years, 2 months ago (2016-10-24 00:01:45 UTC) #7
Timothy Loh
lgtm
4 years, 2 months ago (2016-10-24 00:05:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435413002/1
4 years, 2 months ago (2016-10-24 08:00:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-24 10:00:07 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-24 10:01:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19dbf3f3adb3bc0406cf8b5862b2bede11d6f36b
Cr-Commit-Position: refs/heads/master@{#427036}

Powered by Google App Engine
This is Rietveld 408576698