Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2435343002: Remove unnecessary and spammy NOTIMPLEMENTED() in AutofillClientIOS. (Closed)

Created:
4 years, 2 months ago by Justin Donnelly
Modified:
4 years, 1 month ago
Reviewers:
lindsayw, sdefresne
CC:
chromium-reviews, rouslan+autofill_chromium.org, jdonnelly+autofillwatch_chromium.org, mac-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary and spammy NOTIMPLEMENTED() in AutofillClientIOS. This method is called by the cross-platform autofill code resulting in regular log spam. The calling sites don't expect a non-null return value so there's no need to log this as an error. BUG=658299 Committed: https://crrev.com/9eff2146da825f6b65ab618dde0bb5ee906163a9 Cr-Commit-Position: refs/heads/master@{#427081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Justin Donnelly
4 years, 2 months ago (2016-10-21 17:25:52 UTC) #4
sdefresne
lgtm
4 years, 1 month ago (2016-10-24 15:32:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435343002/1
4 years, 1 month ago (2016-10-24 15:52:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 16:21:16 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 16:49:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9eff2146da825f6b65ab618dde0bb5ee906163a9
Cr-Commit-Position: refs/heads/master@{#427081}

Powered by Google App Engine
This is Rietveld 408576698