[NaCl SDK] Refactor FakeFileRefInterface.

[NaCl SDK] Refactor FakeFileRefInterface.

Move FakeFileRefInterface from fake_pepper_interface_html5_fs.{cc,h} to
fake_file_ref_interface.{cc,h} to share the code with the future code.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Committed: https://crrev.com/2697f5d9f2a47fcd510984c1b1120a5e727824f5
Cr-Commit-Position: refs/heads/master@{#427283}

[chanpatorikku, 2016-10-21 17:01:19]

The CQ bit was checked by chanpatorikku@gmail.com

[commit-bot: I haz the power, 2016-10-21 17:02:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 17:02:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 17:02:07]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[chanpatorikku, 2016-10-21 17:04:53]

Description was changed from

==========
[NaCl SDK] Refactor FakeFileRefInterface.

Move FakeFileRefInterface from fake_pepper_interface_html5_fs.{cc,h} to
fake_file_ref_interface.{cc,h} to share the code with the future code.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files,
and some formats of the files were changed.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor FakeFileRefInterface.

Move FakeFileRefInterface from fake_pepper_interface_html5_fs.{cc,h} to
fake_file_ref_interface.{cc,h} to share the code with the future code.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[chanpatorikku, 2016-10-21 17:10:35]

chanpatorikku@gmail.com changed reviewers:
+ binji@chromium.org, sbc@chromium.org

[chanpatorikku, 2016-10-21 17:10:36]

ptal. Have just attempted to run linux_nacl_sdk, mac_nacl_sdk, and win_nacl_sdk
by checking the CQ bit so failed try jobs can be fixed before asking for a
review.  Please ignore the messages of commit-bot.

[Sam Clegg, 2016-10-21 21:48:03]

On 2016/10/21 17:10:36, chanpatorikku wrote:
> ptal. Have just attempted to run linux_nacl_sdk, mac_nacl_sdk, and
win_nacl_sdk
> by checking the CQ bit so failed try jobs can be fixed before asking for a
> review.  Please ignore the messages of commit-bot.

You should be able to use "CQ dry run" to do this?  Although you may need to be
chromium committer to do this.  I will do a dry run for you now.

[Sam Clegg, 2016-10-21 21:48:08]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 21:48:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 23:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 23:49:24]

Dry run: This issue passed the CQ dry run.

[chanpatorikku, 2016-10-24 12:51:53]

I am not a committer.
I requested to be nominated as a committer twice but did not get a response.

I guess after some tradeoff analysis, the work approach of setting up the
committer status and doing a dry run every time before a review request isn't as
good as that of having try jobs first run after lgtm and fixing any infrequent
try job failures.

The attempt of running linux_nacl_sdk, mac_nacl_sdk, and win_nacl_sdk was
because of not knowing information enough.  If linux_nacl_sdk, mac_nacl_sdk, and
win_nacl_sdk can be run before lgtm for non-committers, nomination isn't quite
needed for the codes I have asked for reviews.

I can just request nomination again if the try job failures are too frequent and
slow the review a lot.

Thanks for running the try jobs for me.

[Sam Clegg, 2016-10-24 19:52:54]

On 2016/10/24 12:51:53, chanpatorikku wrote:
> I am not a committer.
> I requested to be nominated as a committer twice but did not get a response.
> 
> I guess after some tradeoff analysis, the work approach of setting up the
> committer status and doing a dry run every time before a review request isn't
as
> good as that of having try jobs first run after lgtm and fixing any infrequent
> try job failures.
> 
> The attempt of running linux_nacl_sdk, mac_nacl_sdk, and win_nacl_sdk was
> because of not knowing information enough.  If linux_nacl_sdk, mac_nacl_sdk,
and
> win_nacl_sdk can be run before lgtm for non-committers, nomination isn't quite
> needed for the codes I have asked for reviews.
> 
> I can just request nomination again if the try job failures are too frequent
and
> slow the review a lot.
> 

I think its OK to ask reviewers to run tryjobs on your behalf for now.  Failures
should only occur when there are platform differences (i.e. when you develop on
linux but can't test on windows and the windows build breaks for some reason
that doesn't also break the linux build).

> Thanks for running the try jobs for me.

[Sam Clegg, 2016-10-24 19:54:32]

On 2016/10/24 19:52:54, Sam Clegg wrote:
> On 2016/10/24 12:51:53, chanpatorikku wrote:
> > I am not a committer.
> > I requested to be nominated as a committer twice but did not get a response.
> > 
> > I guess after some tradeoff analysis, the work approach of setting up the
> > committer status and doing a dry run every time before a review request
isn't
> as
> > good as that of having try jobs first run after lgtm and fixing any
infrequent
> > try job failures.
> > 
> > The attempt of running linux_nacl_sdk, mac_nacl_sdk, and win_nacl_sdk was
> > because of not knowing information enough.  If linux_nacl_sdk, mac_nacl_sdk,
> and
> > win_nacl_sdk can be run before lgtm for non-committers, nomination isn't
quite
> > needed for the codes I have asked for reviews.
> > 
> > I can just request nomination again if the try job failures are too frequent
> and
> > slow the review a lot.
> > 
> 
> I think its OK to ask reviewers to run tryjobs on your behalf for now. 
Failures
> should only occur when there are platform differences (i.e. when you develop
on
> linux but can't test on windows and the windows build breaks for some reason
> that doesn't also break the linux build).
> 
> > Thanks for running the try jobs for me.

Also, lgtm :) Thanks for the contributions

[chanpatorikku, 2016-10-25 03:53:59]

The CQ bit was checked by chanpatorikku@gmail.com

[commit-bot: I haz the power, 2016-10-25 03:54:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 05:47:53]

Description was changed from

==========
[NaCl SDK] Refactor FakeFileRefInterface.

Move FakeFileRefInterface from fake_pepper_interface_html5_fs.{cc,h} to
fake_file_ref_interface.{cc,h} to share the code with the future code.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor FakeFileRefInterface.

Move FakeFileRefInterface from fake_pepper_interface_html5_fs.{cc,h} to
fake_file_ref_interface.{cc,h} to share the code with the future code.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[commit-bot: I haz the power, 2016-10-25 05:47:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-25 05:50:21]

Description was changed from

==========
[NaCl SDK] Refactor FakeFileRefInterface.

Move FakeFileRefInterface from fake_pepper_interface_html5_fs.{cc,h} to
fake_file_ref_interface.{cc,h} to share the code with the future code.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor FakeFileRefInterface.

Move FakeFileRefInterface from fake_pepper_interface_html5_fs.{cc,h} to
fake_file_ref_interface.{cc,h} to share the code with the future code.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Committed: https://crrev.com/2697f5d9f2a47fcd510984c1b1120a5e727824f5
Cr-Commit-Position: refs/heads/master@{#427283}
==========

[commit-bot: I haz the power, 2016-10-25 05:50:21]

Patchset 1 (id:??) landed as
https://crrev.com/2697f5d9f2a47fcd510984c1b1120a5e727824f5
Cr-Commit-Position: refs/heads/master@{#427283}