Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: pkg/analyzer/test/src/context/context_test.dart

Issue 2435313002: More improvements to DeclarationResolver. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/declaration_resolver_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/context/context_test.dart
diff --git a/pkg/analyzer/test/src/context/context_test.dart b/pkg/analyzer/test/src/context/context_test.dart
index 19352ab88d4999a1cc3f54b5a073ec3d9338e22d..7c6c668d6744c4215594d602787e14ebce7a27d9 100644
--- a/pkg/analyzer/test/src/context/context_test.dart
+++ b/pkg/analyzer/test/src/context/context_test.dart
@@ -5257,7 +5257,11 @@ class _ElementComparer extends GeneralizingElementVisitor {
@override
void visitElement(Element element) {
Element previousElement = previousElements[element];
- if (!identical(previousElement, element)) {
+ bool expectIdentical = element is! LocalVariableElement;
+ bool ok = expectIdentical
+ ? identical(previousElement, element)
+ : previousElement == element;
+ if (!ok) {
if (overwrittenCount == 0) {
buffer.writeln();
}
« no previous file with comments | « pkg/analyzer/test/generated/declaration_resolver_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698