Issue 2435273003: runtime: Use Linux timezone implementation on Fuchsia

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2435273003: runtime: Use Linux timezone implementation on Fuchsia (Closed)

Created:
4 years, 2 months ago by mikejurka

Modified:
4 years, 2 months ago

Reviewers:
zra, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

runtime: Use Linux timezone implementation on Fuchsia BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/c9537f56e49ad3f7178e0baec7c2764d900bba51

Patch Set 1 #

Total comments: 2

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
	M	runtime/vm/os_fuchsia.cc	View		1 chunk	+22 lines, -8 lines	2 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

lgtm I'll patch this in and land it for you. https://codereview.chromium.org/2435273003/diff/1/runtime/vm/os_fuchsia.cc File runtime/vm/os_fuchsia.cc (right): https://codereview.chromium.org/2435273003/diff/1/runtime/vm/os_fuchsia.cc#newcode59 ...

4 years, 2 months ago (2016-10-22 06:40:56 UTC) #4

zra

4 years, 2 months ago (2016-10-22 06:42:12 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c9537f56e49ad3f7178e0baec7c2764d900bba51 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages