content/renderer/presentation/presentation_dispatcher.cc - Issue 2435243002: [Presentation API] add 'connecting' state to WebPresentationConnectionState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/presentation/presentation_dispatcher.cc

Issue 2435243002: [Presentation API] add 'connecting' state to WebPresentationConnectionState (Closed)

Patch Set: resolve code review comments from mlamouri Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/presentation/presentation_dispatcher.cc

diff --git a/content/renderer/presentation/presentation_dispatcher.cc b/content/renderer/presentation/presentation_dispatcher.cc

index 1299a45e107df015ec592635507dd02a293c60d4..325cac65c7892474fdff2f974d21d4bd3557c4bf 100644

--- a/content/renderer/presentation/presentation_dispatcher.cc

+++ b/content/renderer/presentation/presentation_dispatcher.cc

@@ -45,7 +45,8 @@ blink::WebPresentationError::ErrorType GetWebPresentationErrorTypeFromMojo(

blink::WebPresentationConnectionState GetWebPresentationConnectionStateFromMojo(

blink::mojom::PresentationConnectionState mojoSessionState) {

switch (mojoSessionState) {

- // TODO(imcheng): Add Connecting state to Blink (crbug.com/575351).

+ case blink::mojom::PresentationConnectionState::CONNECTING:

+ return blink::WebPresentationConnectionState::Connecting;

case blink::mojom::PresentationConnectionState::CONNECTED:

return blink::WebPresentationConnectionState::Connected;

case blink::mojom::PresentationConnectionState::CLOSED: