Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: LayoutTests/storage/indexeddb/error-causes-abort-by-default-expected.txt

Issue 243523003: Fire window.onerror for uncaught IndexedDB errors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased and linkage fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/storage/indexeddb/error-causes-abort-by-default-expected.txt
diff --git a/LayoutTests/storage/indexeddb/error-causes-abort-by-default-expected.txt b/LayoutTests/storage/indexeddb/error-causes-abort-by-default-expected.txt
index d7c5857f58453e54924297a3efc55f57fa53eeb4..5bf0ee0e3489ca11e0ccb59dbd1d29f4f3a3632d 100644
--- a/LayoutTests/storage/indexeddb/error-causes-abort-by-default-expected.txt
+++ b/LayoutTests/storage/indexeddb/error-causes-abort-by-default-expected.txt
@@ -1,3 +1,5 @@
+CONSOLE ERROR: line 1: ConstraintError: Key already exists in the object store.
+CONSOLE ERROR: line 1: ConstraintError: Key already exists in the object store.
Verify that a transaction with an error aborts unless preventDefault() is called.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
@@ -10,6 +12,8 @@ setVersionSuccess():
trans = event.target.transaction
PASS trans is non-null.
db.createObjectStore('storeName', null)
+
+Test: prevent the default event behavior prevents the transaction from aborting
trans = db.transaction(['storeName'], 'readwrite')
trans.onabort = unexpectedAbortCallback
trans.oncomplete = transactionCompleted
@@ -19,7 +23,7 @@ event.target.source.add({x: 'value', y: 'zzz'}, 'key')
event.preventDefault()
PASS Transaction completed
-
+Test: allowing the default event behavior, which aborts the transaction
trans = db.transaction(['storeName'], 'readwrite')
trans.onabort = transactionAborted1
trans.oncomplete = unexpectedCompleteCallback
@@ -28,13 +32,13 @@ store.add({x: 'value', y: 'zzz'}, 'key')
Doing nothing to prevent the default action...
PASS Transaction aborted
-
+Test: no error handler implicitly allows allowing the default event behavior, which aborts the transaction
trans = db.transaction(['storeName'], 'readwrite')
trans.onabort = transactionAborted2
trans.oncomplete = unexpectedCompleteCallback
store = trans.objectStore('storeName')
store.add({x: 'value', y: 'zzz'}, 'key')
-Omitting an onerror handler
+Omitting an onerror handler on request; transaction should abort
PASS Transaction aborted
PASS successfullyParsed is true

Powered by Google App Engine
This is Rietveld 408576698