Fire window.onerror for uncaught IndexedDB errors

Source/modules/indexeddb/IDBRequest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 13 matching lines @@
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "modules/indexeddb/IDBRequest.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
+#include "bindings/core/v8/ScriptCallStackFactory.h"
 #include "bindings/modules/v8/IDBBindingUtilities.h"
 #include "core/dom/ExecutionContext.h"
+#include "core/events/ErrorEvent.h"
 #include "core/events/EventQueue.h"
+#include "core/inspector/ScriptCallFrame.h"
+#include "core/inspector/ScriptCallStack.h"
 #include "modules/indexeddb/IDBCursorWithValue.h"
 #include "modules/indexeddb/IDBDatabase.h"
 #include "modules/indexeddb/IDBEventDispatcher.h"
 #include "modules/indexeddb/IDBTracing.h"
 #include "platform/SharedBuffer.h"
 #include "public/platform/WebBlobInfo.h"
 
 using blink::WebIDBCursor;
 
 namespace WebCore {
@@ skipping 18 matching lines @@
     , m_source(source)
     , m_hasPendingActivity(true)
     , m_cursorType(IndexedDB::CursorKeyAndValue)
     , m_cursorDirection(blink::WebIDBCursorDirectionNext)
     , m_pendingCursor(nullptr)
     , m_didFireUpgradeNeededEvent(false)
     , m_preventPropagation(false)
     , m_resultDirty(true)
 {
     ScriptWrappable::init(this);
+
+    m_creationStackTrace = createScriptCallStack(ScriptCallStack::maxCallStackSizeToCapture, false);

[aandrey, 2014/07/08 18:40:16]

Probably we should collect the stacks only when DevTools is open. We don't
collect stacks in other places (like if exception is thrown) in Blink as well as
in V8 unless DevTools is open.

Also this looks very similar to the Promise uncaught async exception issue:
https://code.google.com/p/v8/issues/detail?id=3093

For example, is there the same issue with this async exception, as to whether
it's actually "uncaught" or not at the time it's fired. One could attach a
req.onerror handler later asynchronously, and probably this handler should be
invoked instead of window.onerror.

+    ASSERT(m_creationStackTrace && m_creationStackTrace->size());
 }
 
 IDBRequest::~IDBRequest()
 {
     ASSERT(m_readyState == DONE || m_readyState == EarlyDeath || !executionContext());
     handleBlobAcks();
 }
 
 void IDBRequest::trace(Visitor* visitor)
 {
     visitor->trace(m_transaction);
     visitor->trace(m_source);
     visitor->trace(m_result);
     visitor->trace(m_error);
 #if ENABLE(OILPAN)
     visitor->trace(m_enqueuedEvents);
 #endif
     visitor->trace(m_pendingCursor);
     visitor->trace(m_cursorKey);
     visitor->trace(m_cursorPrimaryKey);
+    visitor->trace(m_creationStackTrace);
     EventTargetWithInlineData::trace(visitor);
 }
 
 ScriptValue IDBRequest::result(ExceptionState& exceptionState)
 {
     if (m_readyState != DONE) {
         exceptionState.throwDOMException(InvalidStateError, IDBDatabase::requestNotFinishedErrorMessage);
         return ScriptValue();
     }
     if (m_contextStopped || !executionContext())
@@ skipping 381 matching lines @@
     }
 
     if (cursorToNotify)
         cursorToNotify->postSuccessHandlerCallback();
 
     // An upgradeneeded event will always be followed by a success or error event, so must
     // be kept alive.
     if (m_readyState == DONE && event->type() != EventTypeNames::upgradeneeded)
         m_hasPendingActivity = false;
 
+    // Fire window.onerror (or the equivalent for workers) for errors that were not prevented.
+    if (!m_preventPropagation && dontPreventDefault && event->type() == EventTypeNames::error) {
+        const ScriptCallFrame& frame = m_creationStackTrace->at(0);
+        const AccessControlStatus corsStatus = NotSharableCrossOrigin;
+        RefPtrWillBeRawPtr<ErrorEvent> errorEvent;
+        if (executionContext()->shouldSanitizeScriptError(frame.sourceURL(), corsStatus)) {
+            errorEvent = ErrorEvent::createSanitizedError(&m_scriptState->world());
+        } else {
+            String message = m_error->name() + ": " + m_error->message();
+            errorEvent = ErrorEvent::create(message, frame.sourceURL(), frame.lineNumber(), frame.columnNumber(), &m_scriptState->world());
+        }
+        executionContext()->reportException(errorEvent, m_creationStackTrace, corsStatus);
+    }
+
     return dontPreventDefault;
 }
 
 void IDBRequest::uncaughtExceptionInEventHandler()
 {
     if (m_transaction && !m_requestAborted) {
         m_transaction->setError(DOMError::create(AbortError, "Uncaught exception in event handler."));
         m_transaction->abort(IGNORE_EXCEPTION);
     }
 }
@@ skipping 34 matching lines @@
 
 void IDBRequest::dequeueEvent(Event* event)
 {
     for (size_t i = 0; i < m_enqueuedEvents.size(); ++i) {
         if (m_enqueuedEvents[i].get() == event)
             m_enqueuedEvents.remove(i);
     }
 }
 
 } // namespace WebCore