Fire window.onerror for uncaught IndexedDB errors

LayoutTests/storage/indexeddb/resources/odd-strings.js

 if (this.importScripts) {
     importScripts('../../../resources/js-test.js');
     importScripts('shared.js');
 }
 
 description("Test IndexedDB odd value datatypes");
 
 function test()
 {
     removeVendorPrefixes();
@@ skipping 18 matching lines @@
             if (++numDeleted == testData.length)
                 openNextDatabase();
         };
     }
 }
 
 function openNextDatabase()
 {
     debug("opening a database named " + testData[nextToOpen].description);
     request = evalAndLog("indexedDB.open(testData[nextToOpen].name, 1)");
-    request.onsuccess = unexpectedSuccessCallback;
     request.onblocked = unexpectedBlockedCallback;
     request.onupgradeneeded = addAKey;
+    request.onsuccess = closeDatabase;

[ericu, 2014/06/19 00:54:05]

Can you talk me through this change?  Why are we now expecting success here?

[jsbell, 2014/06/19 01:13:24]

Previously, the test was closing the database in the 'success' callback of a
request made during the upgrade (`request.onsuccess = closeDatabase;`, below).
Closing the database during the upgrade sequence causes the open request to
fail; this was previously silent but now generates window.onerror spew.

Since that complex flow was completely irrelevant to the test itself, I
simplified the flow - closing the database is now done when the open succeeds.
The alternative was to leave that flow intact, but e.preventDefault() or
expectError().

[ericu, 2014/06/19 01:18:40]

OK.

 }
 
 function addAKey()
 {
     db = event.target.result;
     evalAndLog("objectStore = db.createObjectStore(testData[nextToOpen].name);");
     evalAndLog("index = objectStore.createIndex(testData[nextToOpen].name, 'keyPath');");
     evalAndLog("key = testData[nextToOpen].name");
     evalAndLog("request = objectStore.add(key, key);");
-    request.onsuccess = closeDatabase;
     request.onerror = unexpectedErrorCallback;
 }
 
 function closeDatabase()
 {
     evalAndLog("db.close()");
     debug("");
     if (++nextToOpen < testData.length) {
         openNextDatabase();
     } else {
@@ skipping 28 matching lines @@
     shouldBe("cursor.value", "testData[nextToOpen].name");
     if (++nextToOpen < testData.length) {
         debug("");
         verifyNextDatabase();
     } else {
         finishJSTest();
     }
 }
 
 test();