Issue 2435223002: fix #27644, allow "dart" and "dartx" to be renamed if needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2435223002: fix #27644, allow "dart" and "dartx" to be renamed if needed (Closed)

Created:
4 years, 2 months ago by Jennifer Messerly

Modified:
4 years, 2 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+205 lines, -135 lines)			Patch
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	68 chunks	+191 lines, -130 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/type_utilities.dart	View	3 chunks	+11 lines, -3 lines	0 comments	Download
A +	pkg/dev_compiler/test/codegen/language/variable_named_dart_test.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

touches a lot of lines but mostly was search+replace. see this comment for what the ...

4 years, 2 months ago (2016-10-21 01:45:28 UTC) #2

Jennifer Messerly

4 years, 2 months ago (2016-10-21 18:48:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ce76fc1fe5268a8621b85780fc90b7e829ee9b53 (presubmit successful).