services/service_manager/tests/service_manager/service_manager_unittest.cc - Issue 2435153004: Change Service contract to pass ServiceInfo instead of Identity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/service_manager/tests/service_manager/service_manager_unittest.cc

Issue 2435153004: Change Service contract to pass ServiceInfo instead of Identity (Closed)

Patch Set: . Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/service_manager/tests/service_manager/driver.cc ('k') | services/service_manager/tests/service_manager/target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/service_manager/tests/service_manager/service_manager_unittest.cc

diff --git a/services/service_manager/tests/service_manager/service_manager_unittest.cc b/services/service_manager/tests/service_manager/service_manager_unittest.cc

index 42b15f7964e9bcd393b0681d6dc9e94c1e0cf6e7..5347c1eabd164611c8ce5b16a66cad11e7131023 100644

--- a/services/service_manager/tests/service_manager/service_manager_unittest.cc

+++ b/services/service_manager/tests/service_manager/service_manager_unittest.cc

@@ -38,7 +38,7 @@ class ServiceManagerTestClient

private:

// test::ServiceTestClient:

- bool OnConnect(const Identity& remote_identity,

+ bool OnConnect(const ServiceInfo& remote_info,

InterfaceRegistry* registry) override {

registry->AddInterface<test::mojom::CreateInstanceTest>(this);

return true;