Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: services/service_manager/public/cpp/lib/service_context.cc

Issue 2435153004: Change Service contract to pass ServiceInfo instead of Identity (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/public/cpp/lib/service_context.cc
diff --git a/services/service_manager/public/cpp/lib/service_context.cc b/services/service_manager/public/cpp/lib/service_context.cc
index 42f924147cd7c6f4562cd996b0092e35b2f6b07c..3b4c4220e457ae87101dd79b591cbca789bd3c60 100644
--- a/services/service_manager/public/cpp/lib/service_context.cc
+++ b/services/service_manager/public/cpp/lib/service_context.cc
@@ -57,7 +57,7 @@ void ServiceContext::OnStart(const ServiceInfo& info,
callback.Run(std::move(pending_connector_request_));
- service_->OnStart(identity_);
+ service_->OnStart(info);
}
void ServiceContext::OnConnect(
@@ -70,7 +70,7 @@ void ServiceContext::OnConnect(
identity_, source_info.identity, allowed_interfaces);
registry->Bind(std::move(interfaces));
- if (!service_->OnConnect(source_info.identity, registry.get()))
+ if (!service_->OnConnect(source_info, registry.get()))
return;
// TODO(beng): it appears we never prune this list. We should, when the
« no previous file with comments | « services/service_manager/public/cpp/lib/service.cc ('k') | services/service_manager/public/cpp/lib/service_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698