Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: services/service_manager/tests/lifecycle/package.cc

Issue 2435153004: Change Service contract to pass ServiceInfo instead of Identity (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <memory> 6 #include <memory>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "mojo/public/cpp/bindings/binding_set.h" 10 #include "mojo/public/cpp/bindings/binding_set.h"
(...skipping 23 matching lines...) Expand all
34 destruct_callback_(destruct_callback) { 34 destruct_callback_(destruct_callback) {
35 bindings_.set_connection_error_handler(base::Bind(&PackagedApp::BindingLost, 35 bindings_.set_connection_error_handler(base::Bind(&PackagedApp::BindingLost,
36 base::Unretained(this))); 36 base::Unretained(this)));
37 } 37 }
38 ~PackagedApp() override { 38 ~PackagedApp() override {
39 destruct_callback_.Run(this); 39 destruct_callback_.Run(this);
40 } 40 }
41 41
42 private: 42 private:
43 // service_manager::Service: 43 // service_manager::Service:
44 bool OnConnect(const service_manager::Identity& remote_identity, 44 bool OnConnect(const service_manager::ServiceInfo& remote_info,
45 service_manager::InterfaceRegistry* registry) override { 45 service_manager::InterfaceRegistry* registry) override {
46 registry->AddInterface<LifecycleControl>(this); 46 registry->AddInterface<LifecycleControl>(this);
47 return true; 47 return true;
48 } 48 }
49 49
50 // service_manager::InterfaceFactory<LifecycleControl> 50 // service_manager::InterfaceFactory<LifecycleControl>
51 void Create(const service_manager::Identity& remote_identity, 51 void Create(const service_manager::Identity& remote_identity,
52 LifecycleControlRequest request) override { 52 LifecycleControlRequest request) override {
53 bindings_.AddBinding(this, std::move(request)); 53 bindings_.AddBinding(this, std::move(request));
54 } 54 }
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 public: 97 public:
98 Package() {} 98 Package() {}
99 ~Package() override {} 99 ~Package() override {}
100 100
101 void set_runner(service_manager::ServiceRunner* runner) { 101 void set_runner(service_manager::ServiceRunner* runner) {
102 app_client_.set_runner(runner); 102 app_client_.set_runner(runner);
103 } 103 }
104 104
105 private: 105 private:
106 // service_manager::test::AppClient: 106 // service_manager::test::AppClient:
107 bool OnConnect(const service_manager::Identity& remote_identity, 107 bool OnConnect(const service_manager::ServiceInfo& remote_info,
108 service_manager::InterfaceRegistry* registry) override { 108 service_manager::InterfaceRegistry* registry) override {
109 registry->AddInterface<service_manager::mojom::ServiceFactory>(this); 109 registry->AddInterface<service_manager::mojom::ServiceFactory>(this);
110 return app_client_.OnConnect(remote_identity, registry); 110 return app_client_.OnConnect(remote_info, registry);
111 } 111 }
112 112
113 // service_manager::InterfaceFactory<service_manager::mojom::ServiceFactory>: 113 // service_manager::InterfaceFactory<service_manager::mojom::ServiceFactory>:
114 void Create(const service_manager::Identity& remote_identity, 114 void Create(const service_manager::Identity& remote_identity,
115 service_manager::mojom::ServiceFactoryRequest request) override { 115 service_manager::mojom::ServiceFactoryRequest request) override {
116 bindings_.AddBinding(this, std::move(request)); 116 bindings_.AddBinding(this, std::move(request));
117 } 117 }
118 118
119 // service_manager::mojom::ServiceFactory: 119 // service_manager::mojom::ServiceFactory:
120 void CreateService(service_manager::mojom::ServiceRequest request, 120 void CreateService(service_manager::mojom::ServiceRequest request,
(...skipping 28 matching lines...) Expand all
149 }; 149 };
150 150
151 } // namespace 151 } // namespace
152 152
153 MojoResult ServiceMain(MojoHandle service_request_handle) { 153 MojoResult ServiceMain(MojoHandle service_request_handle) {
154 Package* package = new Package; 154 Package* package = new Package;
155 service_manager::ServiceRunner runner(package); 155 service_manager::ServiceRunner runner(package);
156 package->set_runner(&runner); 156 package->set_runner(&runner);
157 return runner.Run(service_request_handle); 157 return runner.Run(service_request_handle);
158 } 158 }
OLDNEW
« no previous file with comments | « services/service_manager/tests/lifecycle/app_client.cc ('k') | services/service_manager/tests/lifecycle/parent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698