Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2435113002: LogDog: Add Storage-layer data caching. (Closed)

Created:
4 years, 2 months ago by dnj
Modified:
4 years, 1 month ago
Reviewers:
Vadim Sh., nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Add Storage-layer data caching. This adds a generic Storage caching system and a memcache implementation in the Coordinator application. It also integrates that caching into two Storage subsystems: - For BigTable-based Storage, the last "Tail" cursor is cached to speed up subsequent Tail operations. - For Archive-based Storage, the log's index is cached to speed up subsequent log accesses. This switches over "endpoints" Get test to use a memory-backed BigTable implementation instead of a pure memory intermediate storage instance. This exercises more of the real production code paths during gets, including the new caching path. TBR=nodir@chromium.org BUG=chromium:657016 TEST=None Committed: https://github.com/luci/luci-go/commit/36e46653dea3598592b8913583273107c472b540

Patch Set 1 #

Patch Set 2 : Use real BigTable on tests, actually test cache. #

Patch Set 3 : Fix byteLimit bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1115 lines, -254 lines) Patch
M logdog/appengine/coordinator/coordinatorTest/context.go View 1 5 chunks +15 lines, -11 lines 0 comments Download
M logdog/appengine/coordinator/coordinatorTest/service.go View 1 4 chunks +14 lines, -1 line 0 comments Download
A logdog/appengine/coordinator/coordinatorTest/storage_cache.go View 1 1 chunk +70 lines, -0 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/logs/get.go View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M logdog/appengine/coordinator/endpoints/logs/get_test.go View 1 9 chunks +81 lines, -39 lines 0 comments Download
M logdog/appengine/coordinator/service.go View 1 4 chunks +10 lines, -0 lines 0 comments Download
A logdog/appengine/coordinator/storage_cache.go View 1 1 chunk +210 lines, -0 lines 0 comments Download
A logdog/appengine/coordinator/storage_cache_test.go View 1 1 chunk +127 lines, -0 lines 0 comments Download
A logdog/common/storage/archive/cache.go View 1 chunk +37 lines, -0 lines 0 comments Download
M logdog/common/storage/archive/storage.go View 1 6 chunks +56 lines, -33 lines 0 comments Download
M logdog/common/storage/archive/storage_test.go View 3 chunks +31 lines, -2 lines 0 comments Download
M logdog/common/storage/bigtable/bigtable.go View 1 4 chunks +4 lines, -4 lines 0 comments Download
M logdog/common/storage/bigtable/bigtable_test.go View 1 2 chunks +5 lines, -13 lines 0 comments Download
A logdog/common/storage/bigtable/cache.go View 1 1 chunk +68 lines, -0 lines 0 comments Download
M logdog/common/storage/bigtable/initialize.go View 1 1 chunk +1 line, -1 line 0 comments Download
M logdog/common/storage/bigtable/storage.go View 1 6 chunks +25 lines, -5 lines 0 comments Download
M logdog/common/storage/bigtable/storage_test.go View 1 5 chunks +4 lines, -143 lines 0 comments Download
A logdog/common/storage/bigtable/testing.go View 1 1 chunk +187 lines, -0 lines 0 comments Download
A logdog/common/storage/caching/cache.go View 1 1 chunk +81 lines, -0 lines 0 comments Download
A logdog/common/storage/caching/doc.go View 1 chunk +8 lines, -0 lines 0 comments Download
A logdog/common/storage/memory/cache.go View 1 chunk +68 lines, -0 lines 0 comments Download
M logdog/common/storage/memory/memory.go View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
dnj
PTAL. Just throwing this out b/c I have to run for the day, LMK if ...
4 years, 2 months ago (2016-10-20 18:40:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435113002/1
4 years, 1 month ago (2016-10-26 18:22:31 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-26 18:22:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435113002/40001
4 years, 1 month ago (2016-10-27 03:30:24 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 03:35:50 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/36e46653dea3598592b8913583273107c472b540

Powered by Google App Engine
This is Rietveld 408576698