Remove the sign-in menu item on macOS.

Remove the sign-in menu item on macOS.

This CL removes the sign-in menu on macOS as histogram indicate it is very rarely used.

The changes in the XIB file consists in removing this menu item from the menu nib file.

BUG=608181
Committed: https://crrev.com/d51574fc1b1e73878bb6f483543a48a760ca9863
Cr-Commit-Position: refs/heads/master@{#427046}

[msarda, 2016-10-20 15:55:16]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 15:55:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 16:13:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 16:13:20]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[msarda, 2016-10-20 16:30:42]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 16:31:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarda, 2016-10-21 08:04:12]

The CQ bit was checked by msarda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 08:04:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarda, 2016-10-21 08:52:54]

Description was changed from

==========
Remove the sign-in menu item

BUG=608181
==========

to

==========
Remove the sign-in menu item on macOS.

This CL removes the sign-in menu on macOS as histogram indicate it is very
rarely used.

The changes in the XIB file consists in removing this menu item from the menu
nib file.

BUG=608181
==========

[msarda, 2016-10-21 08:53:27]

msarda@chromium.org changed reviewers:
+ mark@chromium.org, rogerta@chromium.org

[msarda, 2016-10-21 08:53:28]

mark@chromium.org: Please review app menu changes chrome/browser and XIB.

rogerta@chromium.org: Please review changes in chrome/browser/signin/

[commit-bot: I haz the power, 2016-10-21 09:01:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 09:01:30]

Dry run: This issue passed the CQ dry run.

[Mark Mentovai, 2016-10-21 16:08:20]

LGTM

[Roger Tawa OOO till Jul 10th, 2016-10-21 17:29:12]

lgtm

If you are doing this cleanup, you may also be able to do more cleanup in
SigninGlobalError.  I don't remember now if there was code in there that was
only still useful for this.

[msarda, 2016-10-22 06:17:19]

msarda@chromium.org changed reviewers:
+ rohitrao@chromium.org

[msarda, 2016-10-22 06:17:20]

Rohit: Please take a look at changes in the XIB file.

[msarda, 2016-10-22 06:23:21]

msarda@chromium.org changed reviewers:
- rohitrao@chromium.org

[msarda, 2016-10-22 06:23:21]

Rohit: Please ignore this review - it looks like Mark is an owner of the XIB
file as well (file
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/OWNERS).

I think the codereview tool is broken and marks the XIB file as not being
covered by an owner.

[msarda, 2016-10-24 08:37:00]

On 2016/10/21 17:29:12, Roger Tawa wrote:
> lgtm
> 
> If you are doing this cleanup, you may also be able to do more cleanup in
> SigninGlobalError.  I don't remember now if there was code in there that was
> only still useful for this.

I've looked at SigninGlobalError, but it looks like the code in there is used
for the Wrench menu error. I suppose that menu item is different than the macOS
menu one, so I do not think I can cleanup code in the class SigninGlobalError.
I'll land this CL as is.

[msarda, 2016-10-24 08:37:08]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2016-10-24 08:37:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 10:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 10:31:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msarda, 2016-10-24 10:40:30]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2016-10-24 10:40:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 11:32:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 11:32:44]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-10-24 11:33:18]

Description was changed from

==========
Remove the sign-in menu item on macOS.

This CL removes the sign-in menu on macOS as histogram indicate it is very
rarely used.

The changes in the XIB file consists in removing this menu item from the menu
nib file.

BUG=608181
==========

to

==========
Remove the sign-in menu item on macOS.

This CL removes the sign-in menu on macOS as histogram indicate it is very
rarely used.

The changes in the XIB file consists in removing this menu item from the menu
nib file.

BUG=608181

Committed: https://crrev.com/d51574fc1b1e73878bb6f483543a48a760ca9863
Cr-Commit-Position: refs/heads/master@{#427046}
==========

[commit-bot: I haz the power, 2016-10-24 11:33:22]

Patchset 4 (id:??) landed as
https://crrev.com/d51574fc1b1e73878bb6f483543a48a760ca9863
Cr-Commit-Position: refs/heads/master@{#427046}