DevTools: restore selection and scrollposition between network and filesystem

third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 77 matching lines @@
     _onBindingCreated: function(event)
     {
         var binding = /** @type {!WebInspector.PersistenceBinding} */(event.data);
         var networkTabId = this._tabIds.get(binding.network);
         var fileSystemTabId = this._tabIds.get(binding.fileSystem);
 
         if (networkTabId)
             this._tabbedPane.changeTabTitle(networkTabId, this._titleForFile(binding.fileSystem), this._tooltipForFile(binding.fileSystem));
         if (!fileSystemTabId)
             return;
+
         var wasSelectedInFileSystem = this._currentFile === binding.fileSystem;
+        var currentSelectionRange = this._history.selectionRange(binding.fileSystem.url());
+        var currentScrollLineNumber = this._history.scrollLineNumber(binding.fileSystem.url());
+
         var tabIndex = this._tabbedPane.tabIndex(fileSystemTabId);
-        this._closeTabs([fileSystemTabId]);
+        this._closeTabs([fileSystemTabId], true);
         if (!networkTabId)
             networkTabId = this._appendFileTab(binding.network, false, tabIndex);
+        this._updateHistory();
+
         if (wasSelectedInFileSystem)
             this._tabbedPane.selectTab(networkTabId, false);
+
+        var networkTabView = /** @type {!WebInspector.Widget} */(this._tabbedPane.tabView(networkTabId));
+        this._restoreEditorProperties(networkTabView, currentSelectionRange, currentScrollLineNumber);
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onBindingRemoved: function(event)
     {
         var binding = /** @type {!WebInspector.PersistenceBinding} */(event.data);
         var networkTabId = this._tabIds.get(binding.network);
         if (!networkTabId)
             return;
-        this._appendFileTab(binding.fileSystem, false);
+
+        var fileSystemTabId = this._appendFileTab(binding.fileSystem, false);
+        this._updateHistory();
+
+        var fileSystemTabView = /** @type {!WebInspector.Widget} */(this._tabbedPane.tabView(fileSystemTabId));
+        var savedSelectionRange = this._history.selectionRange(binding.network.url());
+        var savedScrollLineNumber = this._history.scrollLineNumber(binding.network.url());
+        this._restoreEditorProperties(fileSystemTabView, savedSelectionRange, savedScrollLineNumber);
     },
 
     /**
      * @return {!WebInspector.Widget}
      */
     get view()
     {
         return this._tabbedPane;
     },
 
@@ skipping 100 matching lines @@
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _scrollChanged: function(event)
     {
         if (this._scrollTimer)
             clearTimeout(this._scrollTimer);
         var lineNumber = /** @type {number} */ (event.data);
-        this._scrollTimer = setTimeout(updateHistory.bind(this, this._currentFile.url(), lineNumber), 100);
+        this._scrollTimer = setTimeout(saveHistory.bind(this), 100);
+        this._history.updateScrollLineNumber(this._currentFile.url(), lineNumber);
 
         /**
-         * @param {string} url
-         * @param {number} lineNumber
          * @this {WebInspector.TabbedEditorContainer}
          */
-        function updateHistory(url, lineNumber)
+        function saveHistory()
         {
-            this._history.updateScrollLineNumber(url, lineNumber);
             this._history.save(this._previouslyViewedFilesSetting);
         }
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _selectionChanged: function(event)
     {
         var range = /** @type {!WebInspector.TextRange} */ (event.data);
@@ skipping 63 matching lines @@
             if (nextTabId)
                 this._tabbedPane.selectTab(nextTabId, true);
             this._tabbedPane.closeTab(id, true);
             return true;
         }
         return false;
     },
 
     /**
      * @param {!Array.<string>} ids
+     * @param {boolean=} forceCloseDirtyTabs
      */
-    _closeTabs: function(ids)
+    _closeTabs: function(ids, forceCloseDirtyTabs)
     {
         var dirtyTabs = [];
         var cleanTabs = [];
         for (var i = 0; i < ids.length; ++i) {
             var id = ids[i];
             var uiSourceCode = this._files[id];
-            if (uiSourceCode.isDirty())
+            if (!forceCloseDirtyTabs && uiSourceCode.isDirty())
                 dirtyTabs.push(id);
             else
                 cleanTabs.push(id);
         }
         if (dirtyTabs.length)
             this._tabbedPane.selectTab(dirtyTabs[0], true);
         this._tabbedPane.closeTabs(cleanTabs, true);
         for (var i = 0; i < dirtyTabs.length; ++i) {
             var nextTabId = i + 1 < dirtyTabs.length ? dirtyTabs[i + 1] : null;
             if (!this._maybeCloseTab(dirtyTabs[i], nextTabId))
@@ skipping 106 matching lines @@
 
     /**
      * @param {!WebInspector.UISourceCode} uiSourceCode
      * @param {boolean=} userGesture
      * @param {number=} index
      * @return {string}
      */
     _appendFileTab: function(uiSourceCode, userGesture, index)
     {
         var view = this._delegate.viewForFile(uiSourceCode);
-        var sourceFrame = view instanceof WebInspector.SourceFrame ? /** @type {!WebInspector.SourceFrame} */ (view) : null;
         var title = this._titleForFile(uiSourceCode);
         var tooltip = this._tooltipForFile(uiSourceCode);
 
         var tabId = this._generateTabId();
         this._tabIds.set(uiSourceCode, tabId);
         this._files[tabId] = uiSourceCode;
 
         var savedSelectionRange = this._history.selectionRange(uiSourceCode.url());
-        if (sourceFrame && savedSelectionRange)
-            sourceFrame.setSelection(savedSelectionRange);
         var savedScrollLineNumber = this._history.scrollLineNumber(uiSourceCode.url());
-        if (sourceFrame && savedScrollLineNumber)
-            sourceFrame.scrollToLine(savedScrollLineNumber);
+        this._restoreEditorProperties(view, savedSelectionRange, savedScrollLineNumber);
 
         this._tabbedPane.appendTab(tabId, title, view, tooltip, userGesture, undefined, index);
 
         this._updateFileTitle(uiSourceCode);
         this._addUISourceCodeListeners(uiSourceCode);
         return tabId;
     },
 
     /**
+     * @param {!WebInspector.Widget} editorView
+     * @param {!WebInspector.TextRange=} selection
+     * @param {number=} firstLineNumber
+     */
+    _restoreEditorProperties: function(editorView, selection, firstLineNumber)
+    {
+        var sourceFrame = editorView instanceof WebInspector.SourceFrame ? /** @type {!WebInspector.SourceFrame} */ (editorView) : null;
+        if (!sourceFrame)
+            return;
+        if (selection)
+            sourceFrame.setSelection(selection);
+        if (typeof firstLineNumber === "number")
+            sourceFrame.scrollToLine(firstLineNumber);
+    },
+
+    /**
      * @param {!WebInspector.Event} event
      */
     _tabClosed: function(event)
     {
         var tabId = /** @type {string} */ (event.data.tabId);
         var userGesture = /** @type {boolean} */ (event.data.isUserGesture);
 
         var uiSourceCode = this._files[tabId];
         if (this._currentFile === uiSourceCode) {
             this._removeViewListeners();
@@ skipping 318 matching lines @@
     /**
      * @override
      * @param {string} tabId
      * @param {!WebInspector.ContextMenu} contextMenu
      */
     onContextMenu: function(tabId, contextMenu)
     {
         this._editorContainer._onContextMenu(tabId, contextMenu);
     }
 };