DevTools: restore selection and scrollposition between network and filesystem

DevTools: restore selection and scrollposition between network and filesystem

BUG=658089
R=dgozman

Committed: https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8
Cr-Commit-Position: refs/heads/master@{#427268}

[lushnikov, 2016-10-21 01:04:03]

please, take a look

[dgozman, 2016-10-21 02:33:22]

lgtm

Can we have a test?

[lushnikov, 2016-10-21 22:50:31]

While adding a test, it turned out that CodeMirror doesn't fire scroll event if
the scroll was set via API - so I had to add the code in the SourceTextEditor to
fire the event.

Please, take a look

[lushnikov, 2016-10-21 22:50:37]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 22:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 01:17:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 01:17:54]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-10-24 18:14:50]

nice tests! lgtm

https://codereview.chromium.org/2435043003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2435043003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:68:
binding.fileSystem.setWorkingCopy(binding.network.workingCopy());
Can we test working copy as well?

[lushnikov, 2016-10-25 00:45:00]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-10-25 00:45:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2435043003/#ps40001
(title: "add testcase")

[lushnikov, 2016-10-25 00:45:04]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-10-25 00:45:26]

https://codereview.chromium.org/2435043003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
(right):

https://codereview.chromium.org/2435043003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js:68:
binding.fileSystem.setWorkingCopy(binding.network.workingCopy());
On 2016/10/24 18:14:50, dgozman wrote:
> Can we test working copy as well?

Done.

[lushnikov, 2016-10-25 00:45:30]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:46:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 03:48:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-25 03:49:36]

Description was changed from

==========
DevTools: restore selection and scrollposition between network and filesystem

BUG=658089
R=dgozman
==========

to

==========
DevTools: restore selection and scrollposition between network and filesystem

BUG=658089
R=dgozman

Committed: https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8
Cr-Commit-Position: refs/heads/master@{#427268}
==========

[commit-bot: I haz the power, 2016-10-25 03:49:37]

Patchset 3 (id:??) landed as
https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8
Cr-Commit-Position: refs/heads/master@{#427268}