Enable chrome://device-emulator in non-official NDEBUG builds.

chrome/common/url_constants.cc

Index: chrome/common/url_constants.cc
diff --git a/chrome/common/url_constants.cc b/chrome/common/url_constants.cc
index dc35b36f751f2559feaec3b87048d737bc10b6ed..6cd7b6141af8e53a6a4888afedc0286b55baabc7 100644
--- a/chrome/common/url_constants.cc
+++ b/chrome/common/url_constants.cc
@@ -608,111 +608,114 @@ const char kNotificationWelcomeLearnMoreURL[] =
 // Add hosts here to be included in chrome://chrome-urls (about:about).
 // These hosts will also be suggested by BuiltinProvider.
 const char* const kChromeHostURLs[] = {
-  kChromeUIBluetoothInternalsHost,
-  kChromeUICacheHost,
-  kChromeUIChromeURLsHost,
-  kChromeUIComponentsHost,
-  kChromeUICrashesHost,
-  kChromeUICreditsHost,
-  kChromeUIDNSHost,
-  kChromeUIDeviceLogHost,
-  kChromeUIFlagsHost,
-  kChromeUIGCMInternalsHost,
-  kChromeUIHistoryHost,
-  kChromeUIInvalidationsHost,
-  kChromeUILocalStateHost,
-  kChromeUINetExportHost,
-  kChromeUINetInternalsHost,
-  kChromeUINewTabHost,
-  kChromeUIOmniboxHost,
-  kChromeUIPasswordManagerInternalsHost,
-  kChromeUIPolicyHost,
-  kChromeUIPredictorsHost,
-  kChromeUIProfilerHost,
-  kChromeUISignInInternalsHost,
-  kChromeUISuggestionsHost,
-  kChromeUISupervisedUserInternalsHost,
-  kChromeUISyncInternalsHost,
-  kChromeUITaskSchedulerInternalsHost,
-  kChromeUITermsHost,
-  kChromeUIThumbnailListHost,
-  kChromeUITranslateInternalsHost,
-  kChromeUIUsbInternalsHost,
-  kChromeUIUserActionsHost,
-  kChromeUIVersionHost,
-  content::kChromeUIAccessibilityHost,
-  content::kChromeUIAppCacheInternalsHost,
-  content::kChromeUIBlobInternalsHost,
-  content::kChromeUIGpuHost,
-  content::kChromeUIHistogramHost,
-  content::kChromeUIIndexedDBInternalsHost,
-  content::kChromeUIMediaInternalsHost,
-  content::kChromeUINetworkErrorHost,
-  content::kChromeUINetworkErrorsListingHost,
-  content::kChromeUINetworkViewCacheHost,
-  content::kChromeUIServiceWorkerInternalsHost,
-  content::kChromeUITracingHost,
-  content::kChromeUIWebRTCInternalsHost,
+    kChromeUIBluetoothInternalsHost,

[scheib, 2016/10/21 05:52:26]

FYI the indent here is based on "git cl format", automated formatting for the
win.

[michaelpg, 2016/10/22 03:25:29]

The 2-space indentation is quite common, consistent with the rest of the file
(kChromeDebugURLs), and AFAIK acceptable.

For the sake of blame history I would revert this change.

[michaelpg, 2016/10/22 23:28:29]

Acknowledged. Also, I changed my mind -- 2-space indentation apparently is not
acceptable, because this form of array initialization is a braced-init-list, so
the style guide mandates 4 spaces:
https://google.github.io/styleguide/cppguide.html#Braced_Initializer_List_Format

That being said... it would be nice if this file could be made internally
consistent. I wouldn't gate on that, though, just my compilation concerns.

[scheib, 2016/11/03 23:58:59]

Done, corrected the other array as well.

[michaelpg, 2016/11/04 21:20:14]

Thanks.

+    kChromeUICacheHost,
+    kChromeUIChromeURLsHost,
+    kChromeUIComponentsHost,
+    kChromeUICrashesHost,
+    kChromeUICreditsHost,
+    kChromeUIDNSHost,
+#if defined(OS_CHROMEOS)
+    kChromeUIDeviceEmulatorHost,

[michaelpg, 2016/10/22 23:28:29]

Is it OK to include this when the WebUI itself doesn't exist?
* running on Chrome OS, or
* using an official build

[scheib, 2016/11/03 23:58:59]

Done.

+#endif
+    kChromeUIDeviceLogHost,
+    kChromeUIFlagsHost,
+    kChromeUIGCMInternalsHost,
+    kChromeUIHistoryHost,
+    kChromeUIInvalidationsHost,
+    kChromeUILocalStateHost,
+    kChromeUINetExportHost,
+    kChromeUINetInternalsHost,
+    kChromeUINewTabHost,
+    kChromeUIOmniboxHost,
+    kChromeUIPasswordManagerInternalsHost,
+    kChromeUIPolicyHost,
+    kChromeUIPredictorsHost,
+    kChromeUIProfilerHost,
+    kChromeUISignInInternalsHost,
+    kChromeUISuggestionsHost,
+    kChromeUISupervisedUserInternalsHost,
+    kChromeUISyncInternalsHost,
+    kChromeUITaskSchedulerInternalsHost,
+    kChromeUITermsHost,
+    kChromeUIThumbnailListHost,
+    kChromeUITranslateInternalsHost,
+    kChromeUIUsbInternalsHost,
+    kChromeUIUserActionsHost,
+    kChromeUIVersionHost,
+    content::kChromeUIAccessibilityHost,
+    content::kChromeUIAppCacheInternalsHost,
+    content::kChromeUIBlobInternalsHost,
+    content::kChromeUIGpuHost,
+    content::kChromeUIHistogramHost,
+    content::kChromeUIIndexedDBInternalsHost,
+    content::kChromeUIMediaInternalsHost,
+    content::kChromeUINetworkErrorHost,
+    content::kChromeUINetworkErrorsListingHost,
+    content::kChromeUINetworkViewCacheHost,
+    content::kChromeUIServiceWorkerInternalsHost,
+    content::kChromeUITracingHost,
+    content::kChromeUIWebRTCInternalsHost,
 #if !defined(OS_ANDROID)
 #if !defined(OS_CHROMEOS)
-  kChromeUIAppLauncherPageHost,
-#endif
-  kChromeUIBookmarksHost,
-  kChromeUIDownloadsHost,
-  kChromeUIFlashHost,
-  kChromeUIHelpHost,
-  kChromeUIInspectHost,
-  kChromeUIPluginsHost,
-  kChromeUIQuotaInternalsHost,
-  kChromeUISettingsHost,
-  kChromeUISystemInfoHost,
-  kChromeUIUberHost,
+    kChromeUIAppLauncherPageHost,
+#endif
+    kChromeUIBookmarksHost,
+    kChromeUIDownloadsHost,
+    kChromeUIFlashHost,
+    kChromeUIHelpHost,
+    kChromeUIInspectHost,
+    kChromeUIPluginsHost,
+    kChromeUIQuotaInternalsHost,
+    kChromeUISettingsHost,
+    kChromeUISystemInfoHost,
+    kChromeUIUberHost,
 #endif
 #if defined(OS_ANDROID)
-  kChromeUINetExportHost,
-  kChromeUIOfflineInternalsHost,
-  kChromeUIPopularSitesInternalsHost,
-  kChromeUISnippetsInternalsHost,
+    kChromeUINetExportHost,
+    kChromeUIOfflineInternalsHost,
+    kChromeUIPopularSitesInternalsHost,
+    kChromeUISnippetsInternalsHost,
 #endif
 #if defined(OS_CHROMEOS)
-  kChromeUICertificateManagerHost,
-  kChromeUIChooseMobileNetworkHost,
-  kChromeUICryptohomeHost,
-  kChromeUIDriveInternalsHost,
-  kChromeUIFirstRunHost,
-  kChromeUIKeyboardOverlayHost,
-  kChromeUILoginHost,
-  kChromeUINetworkHost,
-  kChromeUIOobeHost,
-  kChromeUIOSCreditsHost,
-  kChromeUIPowerHost,
-  kChromeUIProxySettingsHost,
-  kChromeUIVoiceSearchHost,
+    kChromeUICertificateManagerHost,
+    kChromeUIChooseMobileNetworkHost,
+    kChromeUICryptohomeHost,
+    kChromeUIDriveInternalsHost,
+    kChromeUIFirstRunHost,
+    kChromeUIKeyboardOverlayHost,
+    kChromeUILoginHost,
+    kChromeUINetworkHost,
+    kChromeUIOobeHost,
+    kChromeUIOSCreditsHost,
+    kChromeUIPowerHost,
+    kChromeUIProxySettingsHost,
+    kChromeUIVoiceSearchHost,
 #endif
 #if defined(OS_WIN) || defined(OS_CHROMEOS)
-  kChromeUIDiscardsHost,
+    kChromeUIDiscardsHost,
 #endif
 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_ANDROID)
-  kChromeUILinuxProxyConfigHost,
-  kChromeUISandboxHost,
+    kChromeUILinuxProxyConfigHost,
+    kChromeUISandboxHost,
 #endif
 #if defined(OS_WIN)
-  kChromeUIConflictsHost,
+    kChromeUIConflictsHost,
 #endif
 #if !defined(DISABLE_NACL)
-  kChromeUINaClHost,
+    kChromeUINaClHost,
 #endif
 #if defined(ENABLE_EXTENSIONS)
-  kChromeUIExtensionsHost,
+    kChromeUIExtensionsHost,
 #endif
 #if defined(ENABLE_PRINT_PREVIEW)
-  kChromeUIPrintHost,
+    kChromeUIPrintHost,
 #endif
 #if BUILDFLAG(ENABLE_SERVICE_DISCOVERY)
-  kChromeUIDevicesHost,
+    kChromeUIDevicesHost,
 #endif
 #if defined(ENABLE_WEBRTC)
-  kChromeUIWebRtcLogsHost,
+    kChromeUIWebRtcLogsHost,
 #endif
 };
 const size_t kNumberOfChromeHostURLs = arraysize(kChromeHostURLs);