MD Settings: Update the design of storage manager.

MD Settings: Update the design of storage manager.

This CL updates the layout/colors to match the following latest spec:
https://folio.googleplex.com/md-storage-management-spec

BUG=629438
TEST=manually confirmed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4e7019f515db78dc52d33fb3fbd283915e0d3985
Cr-Commit-Position: refs/heads/master@{#427291}

[fukino, 2016-10-20 13:55:15]

Description was changed from

==========
MD Settings: Update the design of storage manager.

This CL updates the layout/colors to match the following latest spec:
https://folio.googleplex.com/md-storage-management-spec

BUG=629438
TEST=manually confirmed.
==========

to

==========
MD Settings: Update the design of storage manager.

This CL updates the layout/colors to match the following latest spec:
https://folio.googleplex.com/md-storage-management-spec

BUG=629438
TEST=manually confirmed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-10-20 13:56:40]

fukino@chromium.org changed reviewers:
+ michaelpg@chromium.org

[fukino, 2016-10-20 13:56:40]

Hi Michael, could you take a look?

[michaelpg, 2016-10-22 05:08:41]

https://codereview.chromium.org/2435033003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/storage.html (right):

https://codereview.chromium.org/2435033003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/storage.html:62: padding: 16px
16px 12px 48px;
why not just specify -webkit-padding-start/end?

https://codereview.chromium.org/2435033003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/storage.html:184: <button
class="icon-external" is="paper-icon-button-light"></button>
import paper-icon-button-light.html

[fukino, 2016-10-24 07:59:19]

Thanks!

https://codereview.chromium.org/2435033003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/storage.html (right):

https://codereview.chromium.org/2435033003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/storage.html:62: padding: 16px
16px 12px 48px;
On 2016/10/22 05:08:41, michaelpg wrote:
> why not just specify -webkit-padding-start/end?

Replaced 'padding' with (-webkit-)padding-*.
(I blindly followed "Use shorthand notation when possible." in
https://www.chromium.org/developers/web-development-style-guide, but yes, using
-webkit-padding-start looks simpler.)

https://codereview.chromium.org/2435033003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/storage.html:184: <button
class="icon-external" is="paper-icon-button-light"></button>
On 2016/10/22 05:08:41, michaelpg wrote:
> import paper-icon-button-light.html

Done.

[michaelpg, 2016-10-24 21:36:13]

lgtm

https://codereview.chromium.org/2435033003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/storage.html (right):

https://codereview.chromium.org/2435033003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/storage.html:62: padding: 16px
16px 12px 48px;
On 2016/10/24 07:59:19, fukino wrote:
> On 2016/10/22 05:08:41, michaelpg wrote:
> > why not just specify -webkit-padding-start/end?
> 
> Replaced 'padding' with (-webkit-)padding-*.
> (I blindly followed "Use shorthand notation when possible." in
> https://www.chromium.org/developers/web-development-style-guide, but yes,
using
> -webkit-padding-start looks simpler.)

interesting -- I interpret "when possible" to mean it is overridden by "For the
properties that WebKit currently supports, use the RTL-friendly properties" but
it's definitely ambiguous.

[fukino, 2016-10-25 05:55:29]

Thanks!

https://codereview.chromium.org/2435033003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/storage.html (right):

https://codereview.chromium.org/2435033003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/storage.html:62: padding: 16px
16px 12px 48px;
On 2016/10/24 21:36:13, michaelpg wrote:
> On 2016/10/24 07:59:19, fukino wrote:
> > On 2016/10/22 05:08:41, michaelpg wrote:
> > > why not just specify -webkit-padding-start/end?
> > 
> > Replaced 'padding' with (-webkit-)padding-*.
> > (I blindly followed "Use shorthand notation when possible." in
> > https://www.chromium.org/developers/web-development-style-guide, but yes,
> using
> > -webkit-padding-start looks simpler.)
> 
> interesting -- I interpret "when possible" to mean it is overridden by "For
the
> properties that WebKit currently supports, use the RTL-friendly properties"
but
> it's definitely ambiguous.

Your interpretation makes sense to me.

[fukino, 2016-10-25 05:55:46]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-10-25 05:55:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 06:47:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 06:49:20]

Description was changed from

==========
MD Settings: Update the design of storage manager.

This CL updates the layout/colors to match the following latest spec:
https://folio.googleplex.com/md-storage-management-spec

BUG=629438
TEST=manually confirmed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Update the design of storage manager.

This CL updates the layout/colors to match the following latest spec:
https://folio.googleplex.com/md-storage-management-spec

BUG=629438
TEST=manually confirmed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4e7019f515db78dc52d33fb3fbd283915e0d3985
Cr-Commit-Position: refs/heads/master@{#427291}
==========

[commit-bot: I haz the power, 2016-10-25 06:49:21]

Patchset 2 (id:??) landed as
https://crrev.com/4e7019f515db78dc52d33fb3fbd283915e0d3985
Cr-Commit-Position: refs/heads/master@{#427291}