src/full-codegen/x64/full-codegen-x64.cc - Issue 2435023002: Use a different map to distinguish eval contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2435023002: Use a different map to distinguish eval contexts (Closed)

Patch Set: Crankshaft backends and scope deserialization Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 8273e62788b6954cfacb9d3cd3fd0e911b8678e2..a59b50b51eae4345e36ce8e3c5342e2f02b3f2d3 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -189,7 +189,8 @@ void FullCodeGenerator::Generate() {

if (info->scope()->new_target_var() != nullptr) {

__ Push(rdx); // Preserve new target.

}

- FastNewFunctionContextStub stub(isolate());

+ FastNewFunctionContextStub stub(isolate(),

+ info->scope()->is_eval_scope());

__ Set(FastNewFunctionContextDescriptor::SlotsRegister(), slots);

__ CallStub(&stub);

// Result of FastNewFunctionContextStub is always in new space.