Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2435023002: Use a different map to distinguish eval contexts (Closed)
Patch Set: relax dchecks Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index 83a2ae21a6450a4154af6c56d04dfba3c00e22a4..dfe3afbd8b32a4df9cb706c74c818943a71e2149 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -2933,6 +2933,9 @@ void BytecodeGenerator::BuildNewLocalActivationContext() {
.LoadLiteral(scope->scope_info())
.StoreAccumulatorInRegister(args[2])
.CallRuntime(Runtime::kPushModuleContext, args);
+ } else if (scope->is_eval_scope()) {
+ int slot_count = scope->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
+ builder()->CreateEvalContext(slot_count);
adamk 2016/11/12 00:26:05 Does this need the same branch as we have everywhe
Dan Ehrenberg 2016/12/07 05:41:26 Yes, fixed.
} else {
int slot_count = scope->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
if (slot_count <= FastNewFunctionContextStub::kMaximumSlots) {

Powered by Google App Engine
This is Rietveld 408576698