Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/compiler/verifier.cc

Issue 2435023002: Use a different map to distinguish eval contexts (Closed)
Patch Set: Crankshaft backends and scope deserialization Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 603 matching lines...) Expand 10 before | Expand all | Expand 10 after
614 614
615 case IrOpcode::kJSLoadContext: 615 case IrOpcode::kJSLoadContext:
616 // Type can be anything. 616 // Type can be anything.
617 CheckTypeIs(node, Type::Any()); 617 CheckTypeIs(node, Type::Any());
618 break; 618 break;
619 case IrOpcode::kJSStoreContext: 619 case IrOpcode::kJSStoreContext:
620 // Type is empty. 620 // Type is empty.
621 CheckNotTyped(node); 621 CheckNotTyped(node);
622 break; 622 break;
623 case IrOpcode::kJSCreateFunctionContext: 623 case IrOpcode::kJSCreateFunctionContext:
624 case IrOpcode::kJSCreateEvalContext:
624 case IrOpcode::kJSCreateCatchContext: 625 case IrOpcode::kJSCreateCatchContext:
625 case IrOpcode::kJSCreateWithContext: 626 case IrOpcode::kJSCreateWithContext:
626 case IrOpcode::kJSCreateBlockContext: 627 case IrOpcode::kJSCreateBlockContext:
627 case IrOpcode::kJSCreateScriptContext: { 628 case IrOpcode::kJSCreateScriptContext: {
628 // Type is Context, and operand is Internal. 629 // Type is Context, and operand is Internal.
629 Node* context = NodeProperties::GetContextInput(node); 630 Node* context = NodeProperties::GetContextInput(node);
630 // TODO(bmeurer): This should say CheckTypeIs, but we don't have type 631 // TODO(bmeurer): This should say CheckTypeIs, but we don't have type
631 // OtherInternal on certain contexts, i.e. those from OsrValue inputs. 632 // OtherInternal on certain contexts, i.e. those from OsrValue inputs.
632 CheckTypeMaybe(context, Type::OtherInternal()); 633 CheckTypeMaybe(context, Type::OtherInternal());
633 CheckTypeIs(node, Type::OtherInternal()); 634 CheckTypeIs(node, Type::OtherInternal());
(...skipping 983 matching lines...) Expand 10 before | Expand all | Expand 10 after
1617 replacement->op()->EffectOutputCount() > 0); 1618 replacement->op()->EffectOutputCount() > 0);
1618 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1619 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1619 replacement->opcode() == IrOpcode::kFrameState); 1620 replacement->opcode() == IrOpcode::kFrameState);
1620 } 1621 }
1621 1622
1622 #endif // DEBUG 1623 #endif // DEBUG
1623 1624
1624 } // namespace compiler 1625 } // namespace compiler
1625 } // namespace internal 1626 } // namespace internal
1626 } // namespace v8 1627 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/contexts.h » ('j') | src/contexts.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698