Use a different map to distinguish eval contexts

src/flag-definitions.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines all of the flags.  It is separated into different section,
 // for Debug, Release, Logging and Profiling, etc.  To add a new flag, find the
 // correct section, and use one of the DEFINE_ macros, without a trailing ';'.
 //
 // This include does not have a guard, because it is a template-style include,
 // which can be included multiple times in different modes.  It expects to have
@@ skipping 1118 matching lines @@
             "trace the creation of allocation sites")
 
 // code-stubs.cc
 DEFINE_BOOL(print_code_stubs, false, "print code stubs")
 DEFINE_BOOL(test_secondary_stub_cache, false,
             "test secondary stub cache by disabling the primary one")
 
 DEFINE_BOOL(test_primary_stub_cache, false,
             "test primary stub cache by disabling the secondary one")
 
+DEFINE_BOOL(test_small_max_function_context_stub_size, false,

[adamk, 2016/12/14 12:23:31]

Can you elaborate on why a flag was needed here? Did you try creating a test
case that would exceed the real maximum slots and find it was too slow?

[Dan Ehrenberg, 2016/12/14 22:53:31]

Yes, I found that it consistently made my Z620 run out of memory and freeze up.
It also failed in automation. I manually verified that if I turn on the flag and
introduce a bug that makes the bytecode generator always use FUNCTION_SCOPE for
the overflow path, then one of the newly added tests fails. I didn't add a
comment in the source because none of the other flags have comments.

[adamk, 2016/12/15 08:46:52]

Don't think you need to add a comment, this response is what I meant by
"elaborate". Thanks :)

+            "enable testing the function context size overflow path "
+            "by making the maximum size smaller")
 
 // codegen-ia32.cc / codegen-arm.cc
 DEFINE_BOOL(print_code, false, "print generated code")
 DEFINE_BOOL(print_opt_code, false, "print optimized code")
 DEFINE_STRING(print_opt_code_filter, "*", "filter for printing optimized code")
 DEFINE_BOOL(print_unopt_code, false,
             "print unoptimized code before "
             "printing optimized code based on it")
 DEFINE_BOOL(print_code_verbose, false, "print more information for code")
 DEFINE_BOOL(print_builtin_code, false, "print generated code for builtins")
@@ skipping 93 matching lines @@
 #undef DEFINE_ALIAS_FLOAT
 #undef DEFINE_ALIAS_ARGS
 
 #undef FLAG_MODE_DECLARE
 #undef FLAG_MODE_DEFINE
 #undef FLAG_MODE_DEFINE_DEFAULTS
 #undef FLAG_MODE_META
 #undef FLAG_MODE_DEFINE_IMPLICATIONS
 
 #undef COMMA