Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: src/compiler/verifier.cc

Issue 2435023002: Use a different map to distinguish eval contexts (Closed)
Patch Set: Fix ia32 port Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 610
611 case IrOpcode::kJSLoadContext: 611 case IrOpcode::kJSLoadContext:
612 // Type can be anything. 612 // Type can be anything.
613 CheckTypeIs(node, Type::Any()); 613 CheckTypeIs(node, Type::Any());
614 break; 614 break;
615 case IrOpcode::kJSStoreContext: 615 case IrOpcode::kJSStoreContext:
616 // Type is empty. 616 // Type is empty.
617 CheckNotTyped(node); 617 CheckNotTyped(node);
618 break; 618 break;
619 case IrOpcode::kJSCreateFunctionContext: 619 case IrOpcode::kJSCreateFunctionContext:
620 case IrOpcode::kJSCreateEvalContext:
620 case IrOpcode::kJSCreateCatchContext: 621 case IrOpcode::kJSCreateCatchContext:
621 case IrOpcode::kJSCreateWithContext: 622 case IrOpcode::kJSCreateWithContext:
622 case IrOpcode::kJSCreateBlockContext: 623 case IrOpcode::kJSCreateBlockContext:
623 case IrOpcode::kJSCreateScriptContext: { 624 case IrOpcode::kJSCreateScriptContext: {
624 // Type is Context, and operand is Internal. 625 // Type is Context, and operand is Internal.
625 Node* context = NodeProperties::GetContextInput(node); 626 Node* context = NodeProperties::GetContextInput(node);
626 // TODO(bmeurer): This should say CheckTypeIs, but we don't have type 627 // TODO(bmeurer): This should say CheckTypeIs, but we don't have type
627 // OtherInternal on certain contexts, i.e. those from OsrValue inputs. 628 // OtherInternal on certain contexts, i.e. those from OsrValue inputs.
628 CheckTypeMaybe(context, Type::OtherInternal()); 629 CheckTypeMaybe(context, Type::OtherInternal());
629 CheckTypeIs(node, Type::OtherInternal()); 630 CheckTypeIs(node, Type::OtherInternal());
(...skipping 994 matching lines...) Expand 10 before | Expand all | Expand 10 after
1624 replacement->op()->EffectOutputCount() > 0); 1625 replacement->op()->EffectOutputCount() > 0);
1625 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1626 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1626 replacement->opcode() == IrOpcode::kFrameState); 1627 replacement->opcode() == IrOpcode::kFrameState);
1627 } 1628 }
1628 1629
1629 #endif // DEBUG 1630 #endif // DEBUG
1630 1631
1631 } // namespace compiler 1632 } // namespace compiler
1632 } // namespace internal 1633 } // namespace internal
1633 } // namespace v8 1634 } // namespace v8
OLDNEW
« src/ast/scopes.cc ('K') | « src/compiler/typer.cc ('k') | src/contexts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698