Use a different map to distinguish eval contexts

src/interpreter/bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-generator.h"
 
 #include "src/ast/compile-time-value.h"
 #include "src/ast/scopes.h"
 #include "src/code-stubs.h"
 #include "src/compilation-info.h"
@@ skipping 2915 matching lines @@
     // A JSFunction representing a module is called with the module object as
     // its sole argument, which we pass on to PushModuleContext.
     RegisterList args = register_allocator()->NewRegisterList(3);
     builder()
         ->MoveRegister(builder()->Parameter(1), args[0])
         .LoadAccumulatorWithRegister(Register::function_closure())
         .StoreAccumulatorInRegister(args[1])
         .LoadLiteral(scope->scope_info())
         .StoreAccumulatorInRegister(args[2])
         .CallRuntime(Runtime::kPushModuleContext, args);
+  } else if (scope->is_eval_scope()) {
+    int slot_count = scope->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
+    builder()->CreateEvalContext(slot_count);

[adamk, 2016/11/12 00:26:05]

Does this need the same branch as we have everywhere else for kMaximumSlots?

[Dan Ehrenberg, 2016/12/07 05:41:26]

Yes, fixed.

   } else {
     int slot_count = scope->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
     if (slot_count <= FastNewFunctionContextStub::kMaximumSlots) {
       builder()->CreateFunctionContext(slot_count);
     } else {
       builder()->CallRuntime(Runtime::kNewFunctionContext,
                              Register::function_closure());
     }
   }
 }
@@ skipping 246 matching lines @@
 }
 
 Runtime::FunctionId BytecodeGenerator::StoreKeyedToSuperRuntimeId() {
   return is_strict(language_mode()) ? Runtime::kStoreKeyedToSuper_Strict
                                     : Runtime::kStoreKeyedToSuper_Sloppy;
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8