Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2435013004: MD Settings: Fix ChromeVox side effect of constant flickering. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix ChromeVox side effect of constant flickering. ChromeVox adds a pulsing div to the DOM that causes the body to flicker indefinitely, because of scrollbars appearing and disappearing. BUG=657701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dpapad
4 years, 2 months ago (2016-10-20 17:45:11 UTC) #4
michaelpg
non-visible overflow can have weird side effects, and it won't be clear in the future ...
4 years, 2 months ago (2016-10-20 18:09:39 UTC) #6
michaelpg
Does this issue still occur with CVox Next?
3 years, 10 months ago (2017-02-09 21:51:02 UTC) #9
dpapad
3 years, 10 months ago (2017-02-09 23:31:59 UTC) #10
On 2017/02/09 21:51:02, michaelpg wrote:
> Does this issue still occur with CVox Next?

I have not tried with CVox Next. Will close this CL for now, and we can revive
if still relevant.

Powered by Google App Engine
This is Rietveld 408576698