Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: Source/core/rendering/RenderRegion.cpp

Issue 24350009: Reverse style resolution to avoid N^2 walk when building the render tree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixing loops in Regions Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderRegion.cpp
diff --git a/Source/core/rendering/RenderRegion.cpp b/Source/core/rendering/RenderRegion.cpp
index 651b8886e46fc280ce742a434250b37c6968da1b..680a98cd806b1dba8772a9e65a70649226a48631 100644
--- a/Source/core/rendering/RenderRegion.cpp
+++ b/Source/core/rendering/RenderRegion.cpp
@@ -550,7 +550,7 @@ PassRefPtr<RenderStyle> RenderRegion::computeStyleInRegion(const RenderObject* o
void RenderRegion::computeChildrenStyleInRegion(const RenderObject* object)
{
- for (RenderObject* child = object->firstChild(); child; child = child->nextSibling()) {
+ for (RenderObject* child = object->lastChild(); child; child = child->previousSibling()) {
RenderObjectRegionStyleMap::iterator it = m_renderObjectRegionStyle.find(child);
@@ -602,7 +602,7 @@ void RenderRegion::clearObjectStyleInRegion(const RenderObject* object)
m_renderObjectRegionStyle.remove(object);
// Clear the style for the children of this object.
- for (RenderObject* child = object->firstChild(); child; child = child->nextSibling())
+ for (RenderObject* child = object->lastChild(); child; child = child->previousSibling())
clearObjectStyleInRegion(child);
}
« Source/core/dom/shadow/ShadowRoot.cpp ('K') | « Source/core/dom/shadow/ShadowRoot.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698