Add methods to Reading List Model

ios/chrome/browser/reading_list/reading_list_model.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_READING_LIST_READING_LIST_MODEL_H_
 #define IOS_CHROME_BROWSER_READING_LIST_READING_LIST_MODEL_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 61 matching lines @@
                                            const std::string& title) = 0;
 
   // Removes an entry. The removal may be asynchronous, and not happen
   // immediately.
   virtual void RemoveEntryByUrl(const GURL& url) = 0;
 
   // If the |url| is in the reading list and unread, mark it read. If it is in
   // the reading list and read, move it to the top of unread if it is not here
   // already. This may trigger deletion of old read entries.
   virtual void MarkReadByURL(const GURL& url) = 0;
+  // If the |url| is in the reading list and read, mark it unread. If it is in
+  // the reading list and unread, move it to the top of read if it is not here
+  // already.
+  virtual void MarkUnreadByURL(const GURL& url) = 0;
 
   // Methods to mutate an entry. Will locate the relevant entry by URL. Does
   // nothing if the entry is not found.
   virtual void SetEntryTitle(const GURL& url, const std::string& title) = 0;
   virtual void SetEntryDistilledURL(const GURL& url,
                                     const GURL& distilled_url) = 0;
   virtual void SetEntryDistilledState(
       const GURL& url,
       ReadingListEntry::DistillationState state) = 0;
 
   // Observer registration methods. The model will remove all observers upon
   // destruction automatically.
   void AddObserver(ReadingListModelObserver* observer);
   void RemoveObserver(ReadingListModelObserver* observer);
 
   // Helper class that is used to scope batch updates.
   class ScopedReadingListBatchUpdate {
    public:
     explicit ScopedReadingListBatchUpdate(ReadingListModel* model)
         : model_(model) {}
 
     ~ScopedReadingListBatchUpdate() { model_->EndBatchUpdates(); }
 
    private:
     ReadingListModel* model_;
 
     DISALLOW_COPY_AND_ASSIGN(ScopedReadingListBatchUpdate);
   };
 
+  // Remove all reading list entries. Used for tests only.

[Olivier, 2016/10/20 11:25:39]

Removes
Do you need this in the public interface?

[gambard, 2016/10/20 11:51:35]

Done.
I need this for EG test. If you see a better place, please tell.

[Olivier, 2016/10/20 13:38:02]

Unittests use directly ReadingListModelImpl, so you don't need the definition
here.
Alternatively, as there is nothing private in the method and you can add a
egtest helper that does this

while (model->unread_size()) {
 model_->RemoveEntryByUrl(GetUnreadEntryAtIndex(0).url());

[gambard, 2016/10/20 15:43:05]

Done.

+  virtual void ClearModelForTest() = 0;
+
  protected:
   ReadingListModel();
   virtual ~ReadingListModel();
 
   // The observers.
   base::ObserverList<ReadingListModelObserver> observers_;
 
   // Tells model that batch updates have completed. Called from
   // ReadingListBatchUpdateToken dtor.
   virtual void EndBatchUpdates();
 
  private:
   unsigned int current_batch_updates_count_;
 
   DISALLOW_COPY_AND_ASSIGN(ReadingListModel);
 };
 
 #endif  // IOS_CHROME_BROWSER_READING_LIST_READING_LIST_MODEL_H_