Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3199)

Unified Diff: content/test/BUILD.gn

Issue 2434983003: Really include *.content_browsertests.filter in data dependencies of Android. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/BUILD.gn
diff --git a/content/test/BUILD.gn b/content/test/BUILD.gn
index 38b33044eec970d1a0d21062c906cdad68412ef9..ecdda08b05d3885e7ac831936f1cceb474a85fbc 100644
--- a/content/test/BUILD.gn
+++ b/content/test/BUILD.gn
@@ -647,34 +647,31 @@ test("content_browsertests") {
"data/",
"//media/test/data/",
]
-
- if (!is_android) {
- data += [
- "//net/tools/testserver/",
- "//ppapi/tests/test_case.html",
- "//ppapi/tests/test_page.css",
- "//third_party/pyftpdlib/",
- "//third_party/pywebsocket/",
- "//third_party/tlslite/",
- ]
-
- if (is_mac) {
- data += [ "$root_out_dir/Content Shell.app/" ]
- }
- if (is_win) {
- if (symbol_level != 0) {
- data += [ "$root_out_dir/content_browsertests.exe.pdb" ]
- }
- }
- if (is_linux) {
- data += [ "//testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter" ]
- }
-
- if (is_win || is_linux || is_android) {
- data += [ "//testing/buildbot/filters/site-per-process.content_browsertests.filter" ]
- }
+ }
+ if (is_linux || is_mac || is_win) {
+ data += [
+ "//net/tools/testserver/",
+ "//ppapi/tests/test_case.html",
+ "//ppapi/tests/test_page.css",
+ "//third_party/pyftpdlib/",
+ "//third_party/pywebsocket/",
+ "//third_party/tlslite/",
+ ]
+ }
+ if (is_mac) {
+ data += [ "$root_out_dir/Content Shell.app/" ]
+ }
+ if (is_win) {
+ if (symbol_level != 0) {
+ data += [ "$root_out_dir/content_browsertests.exe.pdb" ]
}
}
+ if (is_linux) {
+ data += [ "//testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter" ]
+ }
+ if (is_win || is_linux || is_android) {
+ data += [ "//testing/buildbot/filters/site-per-process.content_browsertests.filter" ]
+ }
defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698