Chromium Code Reviews| Index: ios/web/web_state/ui/crw_web_controller.h |
| diff --git a/ios/web/web_state/ui/crw_web_controller.h b/ios/web/web_state/ui/crw_web_controller.h |
| index a926691bf3179a4439ccee32162a97cccbfea286..d95c41c683e0afec9522ef89c7134ea20037ad59 100644 |
| --- a/ios/web/web_state/ui/crw_web_controller.h |
| +++ b/ios/web/web_state/ui/crw_web_controller.h |
| @@ -72,24 +72,24 @@ class WebStateImpl; |
| // Defaults to NO; this should be enabled before attempting to access the view. |
| @property(nonatomic, assign) BOOL webUsageEnabled; |
| -@property(nonatomic, assign) id<CRWWebDelegate> delegate; |
| +@property(nonatomic, weak) id<CRWWebDelegate> delegate; |
| @property(nonatomic, weak) id<CRWWebUserInterfaceDelegate> UIDelegate; |
| -@property(nonatomic, assign) id<CRWNativeContentProvider> nativeProvider; |
| -@property(nonatomic, assign) |
| - id<CRWSwipeRecognizerProvider> swipeRecognizerProvider; |
| +@property(nonatomic, weak) id<CRWNativeContentProvider> nativeProvider; |
| +@property(nonatomic, weak) id<CRWSwipeRecognizerProvider> |
| + swipeRecognizerProvider; |
| @property(nonatomic, readonly) web::WebState* webState; |
| @property(nonatomic, readonly) web::WebStateImpl* webStateImpl; |
| // The container view used to display content. If the view has been purged due |
| // to low memory, this will recreate it. |
| -@property(nonatomic, readonly) UIView* view; |
| +@property(weak, nonatomic, readonly) UIView* view; |
|
sdefresne
2016/10/19 18:44:07
nit: could you use the same order as above (here a
Eugene But (OOO till 7-30)
2016/10/25 02:26:06
WebController owns a view, so it should probably b
stkhapugin
2016/10/25 16:16:46
Done.
|
| // The web view proxy associated with this controller. |
| -@property(nonatomic, readonly) id<CRWWebViewProxy> webViewProxy; |
| +@property(weak, nonatomic, readonly) id<CRWWebViewProxy> webViewProxy; |
|
Eugene But (OOO till 7-30)
2016/10/25 02:26:05
Should this be strong?
stkhapugin
2016/10/25 16:16:46
Done.
|
| // The view that generates print data when printing. It is nil if printing |
| // is not supported. |
| -@property(nonatomic, readonly) UIView* viewForPrinting; |
| +@property(weak, nonatomic, readonly) UIView* viewForPrinting; |
|
Eugene But (OOO till 7-30)
2016/10/25 02:26:06
Should this be strong?
stkhapugin
2016/10/25 16:16:46
Here and everywhere: a purely readonly property sh
|
| // Content view was reset due to low memory. Use placeholder overlay view on |
| // next creation. |