Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: base/test/scoped_mock_time_message_loop_task_runner_unittest.cc

Issue 2434783002: Use OnceClosure in TestPendingTask (Closed)
Patch Set: +comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/scoped_mock_time_message_loop_task_runner.h" 5 #include "base/test/scoped_mock_time_message_loop_task_runner.h"
6 6
7 #include <deque> 7 #include <deque>
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/bind_helpers.h" 11 #include "base/bind_helpers.h"
12 #include "base/callback_forward.h" 12 #include "base/callback_forward.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/memory/ptr_util.h" 14 #include "base/memory/ptr_util.h"
15 #include "base/memory/ref_counted.h" 15 #include "base/memory/ref_counted.h"
16 #include "base/message_loop/message_loop.h" 16 #include "base/message_loop/message_loop.h"
17 #include "base/test/test_mock_time_task_runner.h" 17 #include "base/test/test_mock_time_task_runner.h"
18 #include "base/test/test_pending_task.h" 18 #include "base/test/test_pending_task.h"
19 #include "base/time/time.h" 19 #include "base/time/time.h"
20 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
21 21
22 namespace base { 22 namespace base {
23 namespace { 23 namespace {
24 24
25 TaskRunner* GetCurrentTaskRunner() { 25 TaskRunner* GetCurrentTaskRunner() {
26 return MessageLoop::current()->task_runner().get(); 26 return MessageLoop::current()->task_runner().get();
27 } 27 }
28 28
29 void AssignTrue(bool* out) {
30 *out = true;
31 }
32
29 // Pops a task from the front of |pending_tasks| and returns it. 33 // Pops a task from the front of |pending_tasks| and returns it.
30 TestPendingTask PopFront(std::deque<TestPendingTask>* pending_tasks) { 34 TestPendingTask PopFront(std::deque<TestPendingTask>* pending_tasks) {
31 TestPendingTask task = pending_tasks->front(); 35 TestPendingTask task = std::move(pending_tasks->front());
32 pending_tasks->pop_front(); 36 pending_tasks->pop_front();
33 return task; 37 return task;
34 } 38 }
35 39
36 class ScopedMockTimeMessageLoopTaskRunnerTest : public testing::Test { 40 class ScopedMockTimeMessageLoopTaskRunnerTest : public testing::Test {
37 public: 41 public:
38 ScopedMockTimeMessageLoopTaskRunnerTest() 42 ScopedMockTimeMessageLoopTaskRunnerTest()
39 : original_task_runner_(new TestMockTimeTaskRunner()) { 43 : original_task_runner_(new TestMockTimeTaskRunner()) {
40 MessageLoop::current()->SetTaskRunner(original_task_runner_); 44 MessageLoop::current()->SetTaskRunner(original_task_runner_);
41 } 45 }
(...skipping 20 matching lines...) Expand all
62 EXPECT_EQ(scoped_task_runner_->task_runner(), GetCurrentTaskRunner()); 66 EXPECT_EQ(scoped_task_runner_->task_runner(), GetCurrentTaskRunner());
63 scoped_task_runner_.reset(); 67 scoped_task_runner_.reset();
64 EXPECT_EQ(original_task_runner(), GetCurrentTaskRunner()); 68 EXPECT_EQ(original_task_runner(), GetCurrentTaskRunner());
65 } 69 }
66 70
67 TEST_F(ScopedMockTimeMessageLoopTaskRunnerTest, 71 TEST_F(ScopedMockTimeMessageLoopTaskRunnerTest,
68 IncompleteTasksAreCopiedToPreviousTaskRunnerAfterDestruction) { 72 IncompleteTasksAreCopiedToPreviousTaskRunnerAfterDestruction) {
69 auto scoped_task_runner_ = 73 auto scoped_task_runner_ =
70 base::MakeUnique<ScopedMockTimeMessageLoopTaskRunner>(); 74 base::MakeUnique<ScopedMockTimeMessageLoopTaskRunner>();
71 75
76 bool task_10_has_run = false;
77 bool task_11_has_run = false;
78
72 Closure task_1 = Bind(&DoNothing); 79 Closure task_1 = Bind(&DoNothing);
73 Closure task_2 = Bind(&DoNothing); 80 Closure task_2 = Bind(&DoNothing);
74 Closure task_10 = Bind(&DoNothing); 81 Closure task_10 = Bind(&AssignTrue, &task_10_has_run);
75 Closure task_11 = Bind(&DoNothing); 82 Closure task_11 = Bind(&AssignTrue, &task_11_has_run);
76 83
77 constexpr TimeDelta task_1_delay = TimeDelta::FromSeconds(1); 84 constexpr TimeDelta task_1_delay = TimeDelta::FromSeconds(1);
78 constexpr TimeDelta task_2_delay = TimeDelta::FromSeconds(2); 85 constexpr TimeDelta task_2_delay = TimeDelta::FromSeconds(2);
79 constexpr TimeDelta task_10_delay = TimeDelta::FromSeconds(10); 86 constexpr TimeDelta task_10_delay = TimeDelta::FromSeconds(10);
80 constexpr TimeDelta task_11_delay = TimeDelta::FromSeconds(11); 87 constexpr TimeDelta task_11_delay = TimeDelta::FromSeconds(11);
81 88
82 constexpr TimeDelta step_time_by = TimeDelta::FromSeconds(5); 89 constexpr TimeDelta step_time_by = TimeDelta::FromSeconds(5);
83 90
84 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_1, task_1_delay); 91 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_1, task_1_delay);
85 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_2, task_2_delay); 92 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_2, task_2_delay);
86 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_10, task_10_delay); 93 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_10, task_10_delay);
87 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_11, task_11_delay); 94 GetCurrentTaskRunner()->PostDelayedTask(FROM_HERE, task_11, task_11_delay);
88 95
89 scoped_task_runner_->task_runner()->FastForwardBy(step_time_by); 96 scoped_task_runner_->task_runner()->FastForwardBy(step_time_by);
90 97
91 scoped_task_runner_.reset(); 98 scoped_task_runner_.reset();
92 99
93 std::deque<TestPendingTask> pending_tasks = 100 std::deque<TestPendingTask> pending_tasks =
94 original_task_runner()->TakePendingTasks(); 101 original_task_runner()->TakePendingTasks();
95 102
96 EXPECT_EQ(2U, pending_tasks.size()); 103 EXPECT_EQ(2U, pending_tasks.size());
97 104
98 TestPendingTask pending_task = PopFront(&pending_tasks); 105 TestPendingTask pending_task = PopFront(&pending_tasks);
99 EXPECT_TRUE(task_10.Equals(pending_task.task)); 106 EXPECT_FALSE(task_10_has_run);
107 std::move(pending_task.task).Run();
108 EXPECT_TRUE(task_10_has_run);
100 EXPECT_EQ(task_10_delay - step_time_by, pending_task.delay); 109 EXPECT_EQ(task_10_delay - step_time_by, pending_task.delay);
101 110
102 pending_task = PopFront(&pending_tasks); 111 pending_task = PopFront(&pending_tasks);
103 EXPECT_TRUE(task_11.Equals(pending_task.task)); 112 EXPECT_FALSE(task_11_has_run);
113 std::move(pending_task.task).Run();
114 EXPECT_TRUE(task_11_has_run);
104 EXPECT_EQ(task_11_delay - step_time_by, pending_task.delay); 115 EXPECT_EQ(task_11_delay - step_time_by, pending_task.delay);
105 } 116 }
106 117
107 } // namespace 118 } // namespace
108 } // namespace base 119 } // namespace base
OLDNEW
« no previous file with comments | « base/test/scoped_mock_time_message_loop_task_runner.cc ('k') | base/test/test_mock_time_task_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698