Issue 243463006: Merge 264451 "Fixes the crash for "learn more" link of the dialo..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243463006: Merge 264451 "Fixes the crash for "learn more" link of the dialo..." (Closed)

Created:
6 years, 8 months ago by Jun Mukai

Modified:
6 years, 8 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews, nkostylev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, dkrahn+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1916/src/

Visibility:
Public.

More Reviews

Description

Merge 264451 "Fixes the crash for "learn more" link of the dialo..." > Fixes the crash for "learn more" link of the dialog for v2 apps. > > It assumed a browser but it might not exist in case of v2 apps. > > BUG=363716 > R=dkrahn@chromium.org, bartfab@chromium.org > > Review URL: https://codereview.chromium.org/236203017 TBR=mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265098

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -9 lines)			Patch
	M	chrome/browser/chromeos/attestation/platform_verification_dialog.h	View		3 chunks	+2 lines, -4 lines	0 comments	Download
	M	chrome/browser/chromeos/attestation/platform_verification_dialog.cc	View		5 chunks	+21 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r265098.

Expand Messages | Collapse Messages