Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2862)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 2434623002: Remove AppBannerManager code to skip secure context checks for tests. (Closed)
Patch Set: Try to get the CQ to run the useful tests. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index bfee3abca008026482e0b83a2a0cc553498de23c..3c6a3b638312e95f488989ac154d66313cdc2f27 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -140,12 +140,6 @@ public class AppBannerManager {
nativeSetTimeDeltaForTesting(days);
}
- /** Disables the HTTPS scheme requirement for testing. */
- @VisibleForTesting
- static void disableSecureSchemeCheckForTesting() {
- nativeDisableSecureSchemeCheckForTesting();
- }
-
/** Sets the weights of direct and indirect page navigations for testing. */
@VisibleForTesting
static void setEngagementWeights(double directEngagement, double indirectEngagement) {
@@ -170,7 +164,6 @@ public class AppBannerManager {
// Testing methods.
private static native void nativeSetTimeDeltaForTesting(int days);
- private static native void nativeDisableSecureSchemeCheckForTesting();
private static native void nativeSetEngagementWeights(double directEngagement,
double indirectEngagement);
private native boolean nativeIsActiveForTesting(long nativeAppBannerManagerAndroid);

Powered by Google App Engine
This is Rietveld 408576698