Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: ui/app_list/presenter/app_list_presenter_impl.cc

Issue 2434573004: Close app list widget when users click outside of the widget (Closed)
Patch Set: Combine 2 if statements and add DCHECK(!is_visible_) before its use. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/app_list/app_list_service_ash.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/presenter/app_list_presenter_impl.cc
diff --git a/ui/app_list/presenter/app_list_presenter_impl.cc b/ui/app_list/presenter/app_list_presenter_impl.cc
index cd181d1657ed606e57ce605f0824b4b262a8eb1d..e6db16a76d1a001b89936e5dee210b80e819e52d 100644
--- a/ui/app_list/presenter/app_list_presenter_impl.cc
+++ b/ui/app_list/presenter/app_list_presenter_impl.cc
@@ -37,6 +37,7 @@ AppListPresenterImpl::AppListPresenterImpl(
}
AppListPresenterImpl::~AppListPresenterImpl() {
+ Dismiss();
sadrul 2016/10/21 15:12:48 Looks like this is a virtual function, and calling
thanhph 2016/10/21 16:09:40 Thank Sadrul! I make Dismiss override final by cha
presenter_delegate_.reset();
// Ensures app list view goes before the controller since pagination model
// lives in the controller and app list view would access it on destruction.
« no previous file with comments | « chrome/browser/ui/ash/app_list/app_list_service_ash.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698