[Autofill] Separate Autofill.CreditCardInfoBar into .Local and .Server

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 01008b11f9b48e9614d25e67e4ea1f0879b0c18a..4ae58b120ef3eaf0f63b987a15e9ab23db5a1c21 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3016,7 +3016,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <owner>isherman@chromium.org</owner>
   <summary>
     The relative frequency with which users accept, deny, or ignore the Autofill
-    credit card info bar prompt.
+    credit card info bar prompt.  Converted to a base histogram as of 10/2016.

[Ilya Sherman, 2016/10/19 23:34:08]

nit: This "converted to a base histogram ..." text will show up for the suffixed
histograms as well.  I'd just omit it.  I think that possibly you can list an
empty suffix in histogram_suffixes and mark that suffix as obsolete with the
given date, but I don't think it's super worth it.

[Jared Saul, 2016/10/20 00:07:06]

Good point; removed.

   </summary>
 </histogram>

[Ilya Sherman, 2016/10/19 23:34:08]

Please add a base="true" attribute for this histogram (it's a brand new
attribute, so there aren't a lot of examples yet, but there are a couple in this
file).

[Jared Saul, 2016/10/20 00:07:06]

Apologies, but could you point out an example?  I couldn't find one when I was
looking earlier.  I also just tried to do this, and presubmit checks fail with:
ERROR:root:Unrecognized attribute "base" in tag "histogram"

[Ilya Sherman, 2016/10/20 00:08:45]

You might need to sync your client to pick up the change:
https://codereview.chromium.org/2426473006/

[Jared Saul, 2016/10/20 00:17:18]

Hadn't synced since yesterday--that did the trick, thanks!  Done.

 
@@ -103633,6 +103633,12 @@ value.
   <affected-histogram name="Media.Audio.Render.BrowserCallbackRegularity"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="AutofillCreditCardInfoBarSaveType" separator=".">
+  <suffix name="Local" label="Local credit card save"/>
+  <suffix name="Server" label="Server/upload credit card save"/>
+  <affected-histogram name="Autofill.CreditCardInfoBar"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="AutofillDataAvailability" separator=".">
   <suffix name="WithNoData" label="no autofill data"/>
   <suffix name="WithOnlyServerData" label="only server autofill data"/>