components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc - Issue 2434543003: [Autofill] Separate Autofill.CreditCardInfoBar into .Local and .Server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc

Issue 2434543003: [Autofill] Separate Autofill.CreditCardInfoBar into .Local and .Server (Closed)

Patch Set: Fixed macro usage; separated into two tests; edited histograms.xml Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc

diff --git a/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc

index 020d5e0df6bc644ec44843d93160cddc3a21c2a4..4ac1475d133f288816e643e4db2da447c2e79ce2 100644

--- a/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc

+++ b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc

@@ -43,7 +43,8 @@ AutofillSaveCardInfoBarDelegateMobile::AutofillSaveCardInfoBarDelegateMobile(

if (legal_message)

LegalMessageLine::Parse(*legal_message, &legal_messages_);

- AutofillMetrics::LogCreditCardInfoBarMetric(AutofillMetrics::INFOBAR_SHOWN);

+ AutofillMetrics::LogCreditCardInfoBarMetric(AutofillMetrics::INFOBAR_SHOWN,

+ upload_);

}

AutofillSaveCardInfoBarDelegateMobile::

@@ -120,7 +121,7 @@ void AutofillSaveCardInfoBarDelegateMobile::LogUserAction(

AutofillMetrics::InfoBarMetric user_action) {

DCHECK(!had_user_interaction_);

- AutofillMetrics::LogCreditCardInfoBarMetric(user_action);

+ AutofillMetrics::LogCreditCardInfoBarMetric(user_action, upload_);

had_user_interaction_ = true;

}

« no previous file with comments | « components/autofill/core/browser/autofill_metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')