Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2434543003: [Autofill] Separate Autofill.CreditCardInfoBar into .Local and .Server (Closed)
Patch Set: Converted to histogram_suffixes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 01008b11f9b48e9614d25e67e4ea1f0879b0c18a..4ae58b120ef3eaf0f63b987a15e9ab23db5a1c21 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3016,7 +3016,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<owner>isherman@chromium.org</owner>
<summary>
The relative frequency with which users accept, deny, or ignore the Autofill
- credit card info bar prompt.
+ credit card info bar prompt. Converted to a base histogram as of 10/2016.
Ilya Sherman 2016/10/19 23:34:08 nit: This "converted to a base histogram ..." text
Jared Saul 2016/10/20 00:07:06 Good point; removed.
</summary>
</histogram>
Ilya Sherman 2016/10/19 23:34:08 Please add a base="true" attribute for this histog
Jared Saul 2016/10/20 00:07:06 Apologies, but could you point out an example? I
Ilya Sherman 2016/10/20 00:08:45 You might need to sync your client to pick up the
Jared Saul 2016/10/20 00:17:18 Hadn't synced since yesterday--that did the trick,
@@ -103633,6 +103633,12 @@ value.
<affected-histogram name="Media.Audio.Render.BrowserCallbackRegularity"/>
</histogram_suffixes>
+<histogram_suffixes name="AutofillCreditCardInfoBarSaveType" separator=".">
+ <suffix name="Local" label="Local credit card save"/>
+ <suffix name="Server" label="Server/upload credit card save"/>
+ <affected-histogram name="Autofill.CreditCardInfoBar"/>
+</histogram_suffixes>
+
<histogram_suffixes name="AutofillDataAvailability" separator=".">
<suffix name="WithNoData" label="no autofill data"/>
<suffix name="WithOnlyServerData" label="only server autofill data"/>
« no previous file with comments | « components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698