Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 24345003: remove Isolate::GetCurrent from Context api functions (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

remove Isolate::GetCurrent from Context api functions R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16877

Patch Set 1 #

Patch Set 2 : lint #

Total comments: 2

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -151 lines) Patch
M include/v8.h View 3 chunks +20 lines, -14 lines 0 comments Download
M samples/lineprocessor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/api.cc View 1 2 6 chunks +41 lines, -65 lines 0 comments Download
M src/d8.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/cctest.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 9 chunks +13 lines, -32 lines 0 comments Download
M test/cctest/test-debug.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 21 chunks +27 lines, -27 lines 0 comments Download
M test/cctest/test-object-observe.cc View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-23 08:45:47 UTC) #1
Michael Starzinger
LGTM with comments. https://codereview.chromium.org/24345003/diff/4001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/24345003/diff/4001/src/api.cc#newcode762 src/api.cc:762: // receiver, so we have to ...
7 years, 3 months ago (2013-09-23 09:24:47 UTC) #2
dcarney
7 years, 3 months ago (2013-09-23 11:26:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r16877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698