| OLD | NEW |
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 GEN_INCLUDE(['options_browsertest_base.js']); | 5 GEN_INCLUDE(['options_browsertest_base.js']); |
| 6 | 6 |
| 7 /** | 7 /** |
| 8 * TestFixture for testing the formatting of settings pages. | 8 * TestFixture for testing the formatting of settings pages. |
| 9 * @extends {testing.Test} | 9 * @extends {testing.Test} |
| 10 * @constructor | 10 * @constructor |
| (...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 125 if (filters[i] == target) | 125 if (filters[i] == target) |
| 126 return true; | 126 return true; |
| 127 } | 127 } |
| 128 return false; | 128 return false; |
| 129 } | 129 } |
| 130 }; | 130 }; |
| 131 | 131 |
| 132 /** | 132 /** |
| 133 * Ensure that radio and checkbox buttons have consistent layout. | 133 * Ensure that radio and checkbox buttons have consistent layout. |
| 134 */ | 134 */ |
| 135 TEST_F('SettingsFormatWebUITest', 'RadioCheckboxStyleCheck', function() { | 135 // TODO(crbug.com/657514) Flakes on linux and chromeos. |
| 136 GEN('#if defined(OS_LINUX) || defined(OS_CHROMEOS)'); |
| 137 GEN('#define MAYBE_RadioCheckboxStyleCheck DISABLED_RadioCheckboxStyleCheck'); |
| 138 GEN('#else'); |
| 139 GEN('#define MAYBE_RadioCheckboxStyleCheck RadioCheckboxStyleCheck'); |
| 140 GEN('#endif // defined(OS_WIN)'); |
| 141 TEST_F('SettingsFormatWebUITest', 'MAYBE_RadioCheckboxStyleCheck', function() { |
| 136 var settings = $('settings'); | 142 var settings = $('settings'); |
| 137 assertTrue(settings != null, 'Unable to access settings'); | 143 assertTrue(settings != null, 'Unable to access settings'); |
| 138 var query = 'input[type=checkbox], input[type=radio]'; | 144 var query = 'input[type=checkbox], input[type=radio]'; |
| 139 var elements = document.querySelectorAll(query); | 145 var elements = document.querySelectorAll(query); |
| 140 assertTrue(elements.length > 0); | 146 assertTrue(elements.length > 0); |
| 141 for (var i = 0; i < elements.length; i++) { | 147 for (var i = 0; i < elements.length; i++) { |
| 142 var element = elements[i]; | 148 var element = elements[i]; |
| 143 if (!findAncestorByClass(element, element.type)) | 149 if (!findAncestorByClass(element, element.type)) |
| 144 this.fail('MISSING_CHECK_WRAPPER', element, element.type); | 150 this.fail('MISSING_CHECK_WRAPPER', element, element.type); |
| 145 } | 151 } |
| (...skipping 21 matching lines...) Expand all Loading... |
| 167 var elements = document.querySelectorAll('input[type=radio]'); | 173 var elements = document.querySelectorAll('input[type=radio]'); |
| 168 for (var i = 0; i < elements.length; i++) { | 174 for (var i = 0; i < elements.length; i++) { |
| 169 var element = elements[i]; | 175 var element = elements[i]; |
| 170 if (!element.name) | 176 if (!element.name) |
| 171 this.fail('MISSING_RADIO_BUTTON_NAME', element); | 177 this.fail('MISSING_RADIO_BUTTON_NAME', element); |
| 172 | 178 |
| 173 if (!element.getAttribute('value')) | 179 if (!element.getAttribute('value')) |
| 174 this.fail('MISSING_RADIO_BUTTON_VALUE', element); | 180 this.fail('MISSING_RADIO_BUTTON_VALUE', element); |
| 175 } | 181 } |
| 176 }); | 182 }); |
| OLD | NEW |