Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js

Issue 2434473004: Disable many tests with flaky accessibility audits. (Closed)
Patch Set: Disable a bunch of flaky tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 GEN_INCLUDE(['options_browsertest_base.js']); 5 GEN_INCLUDE(['options_browsertest_base.js']);
6 GEN('#include "chrome/browser/ui/webui/options/' + 6 GEN('#include "chrome/browser/ui/webui/options/' +
7 'multilanguage_options_browsertest.h"'); 7 'multilanguage_options_browsertest.h"');
8 8
9 /** 9 /**
10 * Test C++ fixture for Language Options WebUI testing. 10 * Test C++ fixture for Language Options WebUI testing.
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 184
185 // Enable when failure is resolved. 185 // Enable when failure is resolved.
186 // AX_FOCUS_01: http://crbug.com/570046 186 // AX_FOCUS_01: http://crbug.com/570046
187 this.accessibilityAuditConfig.ignoreSelectors( 187 this.accessibilityAuditConfig.ignoreSelectors(
188 'focusableElementNotVisibleAndNotAriaHidden', 188 'focusableElementNotVisibleAndNotAriaHidden',
189 '#offer-to-translate-in-this-language'); 189 '#offer-to-translate-in-this-language');
190 }, 190 },
191 }; 191 };
192 192
193 // Make sure the case where no languages are selected is handled properly. 193 // Make sure the case where no languages are selected is handled properly.
194 TEST_F('MultilanguagePreferenceWebUIBrowserTest', 'SelectFromBlank', 194 // TODO(crbug.com/657514) Flakes on linux and chromeos.
195 GEN('#if defined(OS_LINUX) || defined(OS_CHROMEOS)');
196 GEN('#define MAYBE_SelectFromBlank DISABLED_SelectFromBlank');
197 GEN('#else');
198 GEN('#define MAYBE_SelectFromBlank SelectFromBlank');
199 GEN('#endif // defined(OS_WIN)');
200 TEST_F('MultilanguagePreferenceWebUIBrowserTest', 'MAYBE_SelectFromBlank',
195 function() { 201 function() {
196 expectTrue($('language-options-list').selectLanguageByCode('fr')); 202 expectTrue($('language-options-list').selectLanguageByCode('fr'));
197 expectFalse($('spellcheck-language-checkbox').checked, 'fr'); 203 expectFalse($('spellcheck-language-checkbox').checked, 'fr');
198 expectTrue($('edit-custom-dictionary-button').hidden); 204 expectTrue($('edit-custom-dictionary-button').hidden);
199 205
200 // Add a preference change event listener which ensures that the preference is 206 // Add a preference change event listener which ensures that the preference is
201 // updated correctly and that 'fr' is the only thing in the dictionary object. 207 // updated correctly and that 'fr' is the only thing in the dictionary object.
202 this.addPreferenceListener('spellcheck.dictionaries', function() { 208 this.addPreferenceListener('spellcheck.dictionaries', function() {
203 expectTrue($('spellcheck-language-checkbox').checked, 'fr'); 209 expectTrue($('spellcheck-language-checkbox').checked, 'fr');
204 this.expectRegisteredDictionariesPref('fr'); 210 this.expectRegisteredDictionariesPref('fr');
205 this.expectCurrentlySelected('fr'); 211 this.expectCurrentlySelected('fr');
206 expectFalse($('edit-custom-dictionary-button').hidden); 212 expectFalse($('edit-custom-dictionary-button').hidden);
207 testDone(); 213 testDone();
208 }.bind(this)); 214 }.bind(this));
209 215
210 // Click 'fr' and trigger the preference listener. 216 // Click 'fr' and trigger the preference listener.
211 $('spellcheck-language-checkbox').click(); 217 $('spellcheck-language-checkbox').click();
212 }); 218 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698