Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8346)

Unified Diff: ash/shell/shell_delegate_impl.cc

Issue 2434463004: mash: Move directly linked NewWindowDelegate to mojom::NewWindowClient. (Closed)
Patch Set: Actually rename the browser test. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell/shell_delegate_impl.cc
diff --git a/ash/shell/shell_delegate_impl.cc b/ash/shell/shell_delegate_impl.cc
index 5f9c01e06eedd78b3d8fd15bd0081fe834636df5..e27052d218e74ddabe2dc2b7ce5a10d146430dec 100644
--- a/ash/shell/shell_delegate_impl.cc
+++ b/ash/shell/shell_delegate_impl.cc
@@ -9,7 +9,6 @@
#include "ash/common/default_accessibility_delegate.h"
#include "ash/common/gpu_support_stub.h"
#include "ash/common/media_delegate.h"
-#include "ash/common/new_window_delegate.h"
#include "ash/common/palette_delegate.h"
#include "ash/common/session/session_state_delegate.h"
#include "ash/common/system/tray/default_system_tray_delegate.h"
@@ -37,31 +36,6 @@ namespace ash {
namespace shell {
namespace {
-class NewWindowDelegateImpl : public NewWindowDelegate {
- public:
- NewWindowDelegateImpl() {}
- ~NewWindowDelegateImpl() override {}
-
- // NewWindowDelegate:
- void NewTab() override {}
- void NewWindow(bool incognito) override {
- ToplevelWindow::CreateParams create_params;
- create_params.can_resize = true;
- create_params.can_maximize = true;
- ToplevelWindow::CreateToplevelWindow(create_params);
- }
- void OpenFileManager() override {}
- void OpenCrosh() override {}
- void OpenGetHelp() override {}
- void RestoreTab() override {}
- void ShowKeyboardOverlay() override {}
- void ShowTaskManager() override {}
- void OpenFeedbackPage() override {}
-
- private:
- DISALLOW_COPY_AND_ASSIGN(NewWindowDelegateImpl);
-};
-
class MediaDelegateImpl : public MediaDelegate {
public:
MediaDelegateImpl() {}
@@ -269,10 +243,6 @@ AccessibilityDelegate* ShellDelegateImpl::CreateAccessibilityDelegate() {
return new DefaultAccessibilityDelegate;
}
-NewWindowDelegate* ShellDelegateImpl::CreateNewWindowDelegate() {
- return new NewWindowDelegateImpl;
-}
-
MediaDelegate* ShellDelegateImpl::CreateMediaDelegate() {
return new MediaDelegateImpl;
}

Powered by Google App Engine
This is Rietveld 408576698