Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: ui/base/ime/input_method_mac.mm

Issue 2434433006: MacViews: Implement InputMethodMac::CancelComposition. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_mac.mm
diff --git a/ui/base/ime/input_method_mac.mm b/ui/base/ime/input_method_mac.mm
index b03b1620e3f1758361d109a1794036172a841452..93b6db568f90c7046b65d17b995eb85575cf1833 100644
--- a/ui/base/ime/input_method_mac.mm
+++ b/ui/base/ime/input_method_mac.mm
@@ -4,6 +4,8 @@
#include "ui/base/ime/input_method_mac.h"
+#include <Cocoa/Cocoa.h>
tapted 2016/10/25 02:57:57 nit: import
+
namespace ui {
InputMethodMac::InputMethodMac(internal::InputMethodDelegate* delegate) {
@@ -27,6 +29,7 @@
}
void InputMethodMac::CancelComposition(const TextInputClient* client) {
+ [[NSTextInputContext currentInputContext] discardMarkedText];
tapted 2016/10/25 02:57:57 Do we need if (!IsTextInputClientFocused(client
karandeepb 2016/10/25 04:48:59 Added the check.
}
bool InputMethodMac::IsCandidatePopupOpen() const {
« no previous file with comments | « ui/base/ime/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698