Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1663)

Unified Diff: media/mojo/clients/mojo_renderer.cc

Issue 2434413002: Plumb firstPartyForCookies() to MediaPlayerBridge (Closed)
Patch Set: Clarified comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | media/mojo/interfaces/renderer.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/clients/mojo_renderer.cc
diff --git a/media/mojo/clients/mojo_renderer.cc b/media/mojo/clients/mojo_renderer.cc
index 3f0a7c6913474f553f1fdc32ecdab327e147f8c1..7d009d6f0b45ba3321c506d15cbdee5610a985e3 100644
--- a/media/mojo/clients/mojo_renderer.cc
+++ b/media/mojo/clients/mojo_renderer.cc
@@ -112,7 +112,7 @@ void MojoRenderer::InitializeRendererFromStreams(
// |remote_renderer_| is destroyed.
remote_renderer_->Initialize(
std::move(client_ptr_info), std::move(audio_stream),
- std::move(video_stream), base::nullopt,
+ std::move(video_stream), base::nullopt, base::nullopt,
base::Bind(&MojoRenderer::OnInitialized, base::Unretained(this), client));
}
@@ -125,12 +125,15 @@ void MojoRenderer::InitializeRendererFromUrl(media::RendererClient* client) {
mojom::RendererClientAssociatedPtrInfo client_ptr_info;
client_binding_.Bind(&client_ptr_info, remote_renderer_.associated_group());
+ MediaUrlParams url_params = demuxer_stream_provider_->GetMediaUrlParams();
+
// Using base::Unretained(this) is safe because |this| owns
// |remote_renderer_|, and the callback won't be dispatched if
// |remote_renderer_| is destroyed.
remote_renderer_->Initialize(
std::move(client_ptr_info), mojom::DemuxerStreamPtr(),
- mojom::DemuxerStreamPtr(), demuxer_stream_provider_->GetUrl(),
+ mojom::DemuxerStreamPtr(), url_params.media_url,
+ url_params.first_party_for_cookies,
base::Bind(&MojoRenderer::OnInitialized, base::Unretained(this), client));
}
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | media/mojo/interfaces/renderer.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698