media/base/pipeline_impl.cc - Issue 2434413002: Plumb firstPartyForCookies() to MediaPlayerBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/pipeline_impl.cc

Issue 2434413002: Plumb firstPartyForCookies() to MediaPlayerBridge (Closed)

Patch Set: Clarified comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/pipeline_impl.cc

diff --git a/media/base/pipeline_impl.cc b/media/base/pipeline_impl.cc

index b52c64dfef93db2a8b47ebaa3c1bd668c18bcd06..144291b681c66023724c083727b238458f653788 100644

--- a/media/base/pipeline_impl.cc

+++ b/media/base/pipeline_impl.cc

@@ -835,7 +835,7 @@ void PipelineImpl::RendererWrapper::InitializeRenderer(

case DemuxerStreamProvider::Type::URL:

// NOTE: Empty GURL are not valid.

- if (!demuxer_->GetUrl().is_valid()) {

+ if (!demuxer_->GetMediaUrlParams().media_url.is_valid()) {

DVLOG(1) << "Error: demuxer does not have a valid URL.";

done_cb.Run(PIPELINE_ERROR_COULD_NOT_RENDER);

return;

« no previous file with comments | « media/base/media_url_params.h ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »