Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: content/browser/media/android/media_player_renderer.cc

Issue 2434413002: Plumb firstPartyForCookies() to MediaPlayerBridge (Closed)
Patch Set: Added bug number to TODO Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/BUILD.gn » ('j') | media/base/media_url_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/android/media_player_renderer.cc
diff --git a/content/browser/media/android/media_player_renderer.cc b/content/browser/media/android/media_player_renderer.cc
index 756b9a98cb16b7f5d58a35a0f217b6eb498212b1..58d7bfa80db3b9234d48c3883738f18efd989b67 100644
--- a/content/browser/media/android/media_player_renderer.cc
+++ b/content/browser/media/android/media_player_renderer.cc
@@ -42,22 +42,20 @@ void MediaPlayerRenderer::Initialize(
return;
}
- GURL url = demuxer_stream_provider->GetUrl();
+ media::MediaUrlParams url_params =
+ demuxer_stream_provider->GetMediaUrlParams();
renderer_client_ = client;
const std::string user_agent = GetContentClient()->GetUserAgent();
- // TODO(tguilbert): Get the first party cookies from WMPI. See
- // crbug.com/636604.
media_player_.reset(new media::MediaPlayerBridge(
- kUnusedAndIrrelevantPlayerId, url,
- GURL(), // first_party_for_cookies
- user_agent,
+ kUnusedAndIrrelevantPlayerId, url_params.media_url,
+ url_params.first_party_for_cookies, user_agent,
false, // hide_url_log
this, base::Bind(&MediaPlayerRenderer::OnDecoderResourcesReleased,
weak_factory_.GetWeakPtr()),
GURL(), // frame_url
- false)); // allow_crendentials
+ true)); // allow_crendentials
media_player_->Initialize();
init_cb.Run(media::PIPELINE_OK);
« no previous file with comments | « no previous file | media/base/BUILD.gn » ('j') | media/base/media_url_params.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698