Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: media/base/demuxer_stream_provider.h

Issue 2434413002: Plumb firstPartyForCookies() to MediaPlayerBridge (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/demuxer_stream_provider.h
diff --git a/media/base/demuxer_stream_provider.h b/media/base/demuxer_stream_provider.h
index 237e4fabbe37e2d7052c67d2174630286659388f..0cbc22587a08e6b1ce3bf6be54253046294764d6 100644
--- a/media/base/demuxer_stream_provider.h
+++ b/media/base/demuxer_stream_provider.h
@@ -8,6 +8,7 @@
#include "base/macros.h"
#include "media/base/demuxer_stream.h"
#include "media/base/media_export.h"
+#include "media/base/media_url_params.h"
#include "url/gurl.h"
namespace media {
@@ -20,6 +21,7 @@ namespace media {
// "MediaProvider". This class would be a good candidate for renaming, if
// ever Pipeline were to support this class directly, instead of the Demuxer
// interface.
+// TODO(tguilbert): Rename this class.
//
// The derived classes must return a non-null value for the getter method
// associated with their type, and return a null/empty value for other getters.
@@ -42,11 +44,11 @@ class MEDIA_EXPORT DemuxerStreamProvider {
virtual DemuxerStream* GetStream(DemuxerStream::Type type) = 0;
// For Type::URL:
- // Returns the URL of the media to play. This might be an empty URL, and
- // should be handled appropriately by the caller.
+ // Returns the URL parameters of the media to play. Empty URLs are legal,
+ // and should be handled appropriately by the caller.
// Other types:
// Should not be called.
- virtual GURL GetUrl() const;
+ virtual MediaUrlParams GetMediaUrlParams() const;
virtual DemuxerStreamProvider::Type GetType() const;

Powered by Google App Engine
This is Rietveld 408576698