Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2434403002: Revert of [Android] Always use devil's adb in the perf recipes. (RELAND) (Closed)

Created:
4 years, 2 months ago by jbudorick
Modified:
4 years, 2 months ago
CC:
chromium-reviews, nednguyen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Always use devil's adb in the perf recipes. (RELAND) (patchset #2 id:20001 of https://codereview.chromium.org/2438563004/ ) Reason for revert: breaking again. Original issue's description: > [Android] Always use devil's adb in the perf recipes. (RELAND) > > BUG=623989 TBR=stip@chromium.org,dtu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623989 Committed: https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3 Cr-Commit-Position: refs/heads/master@{#426624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -1003 lines) Patch
M infra/recipes/android/perf.py View 1 chunk +0 lines, -16 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 13 chunks +12 lines, -30 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 13 chunks +12 lines, -30 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 13 chunks +12 lines, -30 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json View 13 chunks +12 lines, -30 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json View 13 chunks +12 lines, -30 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json View 13 chunks +12 lines, -30 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/get_perf_test_list_old_data.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/host_info_failure.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/missing_device.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/provision_devices.json View 7 chunks +6 lines, -24 lines 0 comments Download
M infra/recipes/android/perf.expected/src_side_script_fails.json View 12 chunks +11 lines, -29 lines 0 comments Download
M infra/recipes/android/perf.expected/test_failure.json View 12 chunks +11 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
Created Revert of [Android] Always use devil's adb in the perf recipes. (RELAND)
4 years, 2 months ago (2016-10-20 22:40:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434403002/1
4 years, 2 months ago (2016-10-20 22:40:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 22:45:35 UTC) #4
jbudorick
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2437083003/ by jbudorick@chromium.org. ...
4 years, 2 months ago (2016-10-20 22:53:15 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:23:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3
Cr-Commit-Position: refs/heads/master@{#426624}

Powered by Google App Engine
This is Rietveld 408576698