Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: chrome/android/java/res/layout/payments_request_editor_textview.xml

Issue 2434383002: [Payments] Float card scanner icon at the end of EditText instead of compound drawable (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/payments_request_editor_textview.xml
diff --git a/chrome/android/java/res/layout/payments_request_editor_textview.xml b/chrome/android/java/res/layout/payments_request_editor_textview.xml
index db89d5b0d4e4e0e6e5f62b0c0cd72f79b1f80df2..387748da2b3d066a943355673ebeab36c8517c60 100644
--- a/chrome/android/java/res/layout/payments_request_editor_textview.xml
+++ b/chrome/android/java/res/layout/payments_request_editor_textview.xml
@@ -3,10 +3,30 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
-<AutoCompleteTextView
+<FrameLayout
xmlns:android="http://schemas.android.com/apk/res/android"
- android:id="@+id/text_view"
android:layout_width="match_parent"
- android:layout_height="wrap_content"
- android:singleLine="true"
- android:imeOptions="flagNoExtractUi" />
+ android:layout_height="wrap_content">
+
+ <org.chromium.chrome.browser.widget.CompatibilityTextInputLayout
+ android:id="@+id/text_input_layout"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content">
+
+ <AutoCompleteTextView
+ android:id="@+id/text_view"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:singleLine="true"
+ android:imeOptions="flagNoExtractUi" />
+ </org.chromium.chrome.browser.widget.CompatibilityTextInputLayout>
+
+ <ImageView
+ android:id="@+id/action_icon"
+ android:layout_width="48dp"
+ android:layout_height="48dp"
+ android:padding="12dp"
+ android:layout_gravity="end"
+ android:contentDescription="@string/autofill_scan_credit_card"
please use gerrit instead 2016/10/20 22:52:04 The content description should ideally be set from
gogerald1 2016/10/21 01:08:51 Done.
+ android:visibility="gone"/>
+</FrameLayout>

Powered by Google App Engine
This is Rietveld 408576698