chrome/android/java/res/layout/payments_request_editor_textview.xml - Issue 2434383002: [Payments] Float card scanner icon at the end of EditText instead of compound drawable

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/payments_request_editor_textview.xml

Issue 2434383002: [Payments] Float card scanner icon at the end of EditText instead of compound drawable (Closed)

Patch Set: address comments and tint icon Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <AutoCompleteTextView	6 <FrameLayout

7 xmlns:android="http://schemas.android.com/apk/res/android"	7 xmlns:android="http://schemas.android.com/apk/res/android"

8 android:id="@+id/text_view"

9 android:layout_width="match_parent"	8 android:layout_width="match_parent"

10 android:layout_height="wrap_content"	9 android:layout_height="wrap_content">

11 android:singleLine="true"	10

12 android:imeOptions="flagNoExtractUi" />	11 <org.chromium.chrome.browser.widget.CompatibilityTextInputLayout
	Ted C 2016/10/21 17:50:43 what happens if this text is very long? Won't the what happens if this text is very long? Won't the icon overlap it and potentially prevent it from being visible? I feel this needs android:paddingEnd="48dp" or something to ensure that isn't the case. gogerald1 2016/10/21 20:01:34 Done. Add padding programmatically in EditorTextFi Show quoted text On 2016/10/21 17:50:43, Ted C wrote: > what happens if this text is very long? Won't the icon overlap it and > potentially prevent it from being visible? > > I feel this needs android:paddingEnd="48dp" or something to ensure that isn't > the case. Done. Add padding programmatically in EditorTextField.onWindowFocusChanged when action_icon is enabled.
	12 android:id="@+id/text_input_layout"

	13 android:layout_width="match_parent"

	14 android:layout_height="wrap_content">

	15

	16 <AutoCompleteTextView

	17 android:id="@+id/text_view"

	18 android:layout_width="match_parent"

	19 android:layout_height="wrap_content"

	20 android:singleLine="true"

	21 android:imeOptions="flagNoExtractUi" />

	22 </org.chromium.chrome.browser.widget.CompatibilityTextInputLayout>

	23

	24 <ImageView

	25 android:id="@+id/action_icon"

	26 android:layout_width="48dp"

	27 android:layout_height="48dp"

	28 android:padding="12dp"

	29 android:layout_gravity="end"

	30 android:contentDescription="@null"

	31 android:visibility="gone"/>

	32 </FrameLayout>

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java » ('j') | no next file with comments »