Change archive_retry_summary step to happen also when there are new failures.

Change archive_retry_summary step to happen also when there are new failures.

In http://crrev.com/2421733002, I added a step after
"webkit_tests (retry_summary)" that calls archive_layout_test_retry_summary.py
which archives the retry summary JSON along with the layout tests results
in Google Storage.

But, this step was added in a function after a try/finally block, where
if there are failures that didn't occur without the patch, a StepFailure
exception is raised inside the try block (I think) -- so, when there is
a StepFailure raised, the retry results are not archived, which is not
what I wanted.

This CL just changes it so that the archive retry results step is inside
the finally block so that the step should always appear after
"webkit_tests (retry summary)".

BUG=642980
Committed: https://chromium.googlesource.com/chromium/tools/build/+/75023e2d624be7d2535efdb683e05f1697713a1e

[qyearsley, 2016-10-20 20:40:12]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-10-21 03:15:38]

lgtm

[qyearsley, 2016-10-21 16:23:10]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-10-21 16:23:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 16:35:10]

Description was changed from

==========
Change archive_retry_summary step to happen also when there are new failures.

In http://crrev.com/2421733002, I added a step after
"webkit_tests (retry_summary)" that calls archive_layout_test_retry_summary.py
which archives the retry summary JSON along with the layout tests results
in Google Storage.

But, this step was added in a function after a try/finally block, where
if there are failures that didn't occur without the patch, a StepFailure
exception is raised inside the try block (I think) -- so, when there is
a StepFailure raised, the retry results are not archived, which is not
what I wanted.

This CL just changes it so that the archive retry results step is inside
the finally block so that the step should always appear after
"webkit_tests (retry summary)".

BUG=642980
==========

to

==========
Change archive_retry_summary step to happen also when there are new failures.

In http://crrev.com/2421733002, I added a step after
"webkit_tests (retry_summary)" that calls archive_layout_test_retry_summary.py
which archives the retry summary JSON along with the layout tests results
in Google Storage.

But, this step was added in a function after a try/finally block, where
if there are failures that didn't occur without the patch, a StepFailure
exception is raised inside the try block (I think) -- so, when there is
a StepFailure raised, the retry results are not archived, which is not
what I wanted.

This CL just changes it so that the archive retry results step is inside
the finally block so that the step should always appear after
"webkit_tests (retry summary)".

BUG=642980

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/75023e2d624be7d2535e...
==========

[commit-bot: I haz the power, 2016-10-21 16:35:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/75023e2d624be7d2535e...